Repository navigation
Hide upload temp files and remove abandoned ones - #60
Merged
Merged
Conversation
Uploads are written to .upload-<uuid>.part first, and the file list showed those while an upload ran. One left by a container stopped mid-upload stayed for good. Listing now skips them and deletes any untouched for a day. Fixes #58 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #58
What changed
list_files()skips upload temp files (.upload-<32 hex>.part, the exact namesave_uploaded_file()uses) and deletes any that haven't been touched for 24 hours: a running upload writes to its file continuously, so an untouched one was cut off by a container stop, when theexceptcleanup never runs.Testing
pytest: 254 passed, 8 skipped. New tests: temp files aren't listed; a stale one is removed on listing; a running one is kept; names that only look similar (.upload-notes.part, no leading dot, other dotfiles) are still listed; a finished upload leaves no temp file. Two fail without the fix.🤖 Generated with Claude Code