Repository navigation
fix(seo): add image sharing cards to public pages - #264
Merged
Merged
Conversation
Deploying document with
|
| Latest commit: |
30bb576
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f4e5b278.document-7hm.pages.dev |
| Branch Preview URL: | https://fix-social-preview.document-7hm.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Public pages currently expose text-only social metadata, without an image, and the editor has no sharing card. Add image-backed Open Graph and X cards across all 177 generated pages in seven languages, plus the editor, local history and public iframe demo.
Use concise localized homepage sharing copy covering Word, Excel, PowerPoint, PDF annotations, optional AI (Experimental Beta), WebMCP and PWA. Include product artwork for both the website and the repository's separate Social preview setting.
Design Decisions
twitter:card=summary_large_image; include image type, dimensions and matching OG/X image alt text.noindex. Never use file names, query parameters or local document content.Risk Analysis
Low risk: static metadata, artwork, documentation and a bounded preview-wait fix. Editor behavior, route handling, vendor files, hosting policies and local document storage are unchanged. Keep HTTP 404 and vendor pages outside the promotional surface.
Verification
git diff --checkpassed.30bb576716c6f2e8d0b57d49635a87537d90eb8d. The deployed preview served correct static cards for English/Chinese homepages, the PDF page, editor and history; the sharing PNG returned HTTP 200 with the declared 1200 x 630 dimensions.Code Concerns
No blocking findings in the final code review.
Merge Verdict
[APPROVE] Ready for review. All 20 hosted checks passed on
30bb576, including Cloudflare deployment, real preview smoke, standard E2E, Pages-semantics E2E, Docker E2E, timing budgets and lint/validation. A real X card after production deployment remains to be checked.The initial Cloudflare deployment failed during repository cloning after about 16 minutes 40 seconds (
HTTP/2 CANCEL,early EOF,invalid index-pack output), before build or deploy. The initial smoke gate independently exited after five minutes without seeing the check. The follow-up fixes that premature same-repository timeout and triggers a fresh deployment; it does not bypass deployment failures.The repository Social preview is separate from website metadata; the user will upload the supplied GitHub PNG in repository settings. Testing a Twitterbot user agent validates static delivery, not actual X crawler access or cached-card refresh.