Conversation
mirsella
force-pushed
the
fix-nix-dead-context-sighup
branch
3 times, most recently
from
August 9, 2026 12:27
09c2fe1 to
3b0e504
Compare
mirsella
force-pushed
the
fix-nix-dead-context-sighup
branch
from
August 21, 2026 16:27
3b0e504 to
8057fce
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The context tests use a dead PTY with PID 1. Dropping it sent SIGHUP to PID 1, which kills the Nix sandbox and makes the build exit with code 129.
The first commit fixes this by leaving PTY child cleanup to the performer, which already owns it.
The second commit cleans up PTY process state and removes duplicate platform-specific code. It is optional and can be dropped if you would rather keep the fix minimal.
Tests:
cargo +nightly test -p rioterm -p librio -p teletypewritercargo +nightly check --workspace --all-targets