Skip to content

RDoc-3966 [Python, Node.js, Java] Per-database connection string articles - #2584

Open
Danielle9897 wants to merge 1 commit into
ravendb:mainfrom
Danielle9897:RDoc-3966-perDatabaseConnectionStrings
Open

RDoc-3966 [Python, Node.js, Java] Per-database connection string articles#2584
Danielle9897 wants to merge 1 commit into
ravendb:mainfrom
Danielle9897:RDoc-3966-perDatabaseConnectionStrings

Conversation

@Danielle9897

Copy link
Copy Markdown
Member

Issue link

https://issues.hibernatingrhinos.com/issue/RDoc-3966/Python-Node.js-Java-Per-database-connection-string-articles

Additional description

Added Python, Node.js, and Java versions for the per-database connection string articles under:
../integrations/connection-strings/per-database

Type of change

  • Content - docs
  • Content - cloud
  • Content - guides
  • Content - start pages/other
  • New docs feature (consider updating /templates or readme)
  • Bug fix
  • Optimization
  • Other

Changes in docs URLs

  • No changes in docs URLs
  • Articles are restructured, URLs will change, mapping is required (update /scripts/redirects.json file, set Documents Moved PR label)

Changes in UX/UI

  • No changes in UX/UI
  • Changes in UX/UI (include screenshots and description)

@Danielle9897

Copy link
Copy Markdown
Member Author

============================
Node.js
@M4xymm pls review files:

docs/integrations/connection-strings/per-database/content/_add-or-update-connection-string-nodejs.mdx
docs/integrations/connection-strings/per-database/content/_get-connection-strings-nodejs.mdx
docs/integrations/connection-strings/per-database/content/_remove-connection-string-nodejs.mdx

============================
Python
@poissoncorp pls review files:

docs/integrations/connection-strings/per-database/content/_add-or-update-connection-string-python.mdx
docs/integrations/connection-strings/per-database/content/_get-connection-strings-python.mdx
docs/integrations/connection-strings/per-database/content/_remove-connection-string-python.mdx

============================
Java
@LielNagar pls review files:

docs/integrations/connection-strings/per-database/content/_add-or-update-connection-string-java.mdx
docs/integrations/connection-strings/per-database/content/_get-connection-strings-java.mdx
docs/integrations/connection-strings/per-database/content/_remove-connection-string-java.mdx


The Java client provides connection string classes for the `Raven`, `Sql`, `Olap`, `ElasticSearch`, `Queue`
(Kafka, RabbitMQ, Azure Queue Storage, and Amazon SQS), and `Ai` types.
Connection string types that have no matching class in the Java client, such as `Snowflake`, can be defined from Studio.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

such as Snowflake and Azure Service Bus

Comment on lines +132 to +133
For every connection string type, create the matching connection string class
(e.g.: `RavenConnectionString`, `SqlConnectionString`, etc.) and pass it to `PutConnectionStringOperation`.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add:
For `QueueConnectionString`, also set `brokerType` and the matching settings object (for example `QueueBrokerType.KAFKA` with `setKafkaConnectionSettings`). The server rejects a queue connection string that has no broker type.


// Access results:
// ===============
Map<String, RavenConnectionString> ravenConnectionStrings =

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

get by name and type example NPEs when the connection string isn't found. Maybe it worth adding a nullity check


The Java client provides connection string classes for the `Raven`, `Sql`, `Olap`, `ElasticSearch`, `Queue`
(Kafka, RabbitMQ, Azure Queue Storage, and Amazon SQS), and `Ai` types.
Connection string types that have no matching class in the Java client, such as `Snowflake`, can be removed from Studio.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here add Azure Service Bus

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants