Scripts for coverity integration#41
Open
ABIRAMI-S wants to merge 3 commits into
Open
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+11
to
+28
| name: Build sceneset component in github rdkcentral | ||
| runs-on: ubuntu-latest | ||
| container: | ||
| image: ghcr.io/rdkcentral/docker-rdk-ci:latest | ||
|
|
||
| steps: | ||
| - name: Checkout code | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Install dependencies | ||
| run: | | ||
| bash -x build_dependencies.sh | ||
|
|
||
| - name: Native build | ||
| run: | | ||
| bash -x cov_build.sh | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} |
Contributor
Contributor
There was a problem hiding this comment.
Pull request overview
Adds CI automation scripts and a GitHub Actions workflow to build SceneSet (and its external dependencies) in a native/container environment as groundwork for Coverity integration.
Changes:
- Added
build_dependencies.shto install packages, fetch/build third-party dependencies, and install CMake if needed. - Added
cov_build.shto configure and build SceneSet via CMake/Ninja. - Added
.github/workflows/native_full_build.ymlto run the above scripts in a container on pushes/PRs.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
cov_build.sh |
Adds a CMake/Ninja build script for SceneSet. |
build_dependencies.sh |
Adds dependency installation + cloning/building required upstream components. |
.github/workflows/native_full_build.yml |
Adds a CI workflow to run dependency build + native build in a container. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+32
to
+35
| CURRENT_CMAKE_VERSION=$(cmake --version | head -n1 | awk '{print $3}') | ||
| REQUIRED_VERSION="3.16" | ||
| if [ "$(printf '%s\n' "$REQUIRED_VERSION" "$CURRENT_CMAKE_VERSION" | sort -V | head -n1)" != "$REQUIRED_VERSION" ]; then | ||
| echo "Current CMake version $CURRENT_CMAKE_VERSION is less than required $REQUIRED_VERSION" |
Comment on lines
+5
to
+7
| GITHUB_WORKSPACE="${PWD}" | ||
| ls -la ${GITHUB_WORKSPACE} | ||
| cd ${GITHUB_WORKSPACE} |
Comment on lines
+12
to
+19
| apt update | ||
| apt install -y libsqlite3-dev libcurl4-openssl-dev valgrind lcov clang libsystemd-dev \ | ||
| libboost-all-dev libwebsocketpp-dev meson libcunit1 libcunit1-dev curl wget \ | ||
| protobuf-compiler-grpc libgrpc-dev libgrpc++-dev libunwind-dev libgstreamer1.0-dev \ | ||
| libgstreamer-plugins-base1.0-dev libjsoncpp-dev libyaml-cpp-dev ninja-build \ | ||
| libarchive-dev libxml2-dev liblz4-dev libssl-dev openssl pkg-config git | ||
|
|
||
| pip install jsonref |
Comment on lines
+71
to
+81
| git clone --branch R4.4.3 https://github.com/rdkcentral/ThunderTools.git | ||
|
|
||
| git clone --branch R4.4.1 https://github.com/rdkcentral/Thunder.git | ||
|
|
||
| git clone --branch develop https://github.com/rdkcentral/entservices-apis.git | ||
|
|
||
| git clone -b develop https://github.com/rdkcentral/eshelpers.git | ||
|
|
||
| git clone -b v1.2.0 https://github.com/rdkcentral/ralf-utils.git | ||
|
|
||
| git clone -b develop https://github.com/rdkcentral/libPackage.git |
Comment on lines
+24
to
+26
| GITHUB_WORKSPACE="${PWD}" | ||
| ls -la ${GITHUB_WORKSPACE} | ||
| cd ${GITHUB_WORKSPACE} |
Comment on lines
+1
to
+8
| name: Build Component in Native Environment | ||
|
|
||
| on: | ||
| push: | ||
| branches: [ main, 'sprint/**', 'release/**', master, develop ] | ||
| pull_request: | ||
| branches: [ main, 'sprint/**', 'release/**', master, develop ] | ||
|
|
Comment on lines
+13
to
+15
| container: | ||
| image: ghcr.io/rdkcentral/docker-rdk-ci:latest | ||
|
|
Contributor
Comment on lines
+12
to
+17
| apt update | ||
| apt install -y libsqlite3-dev libcurl4-openssl-dev valgrind lcov clang libsystemd-dev \ | ||
| libboost-all-dev libwebsocketpp-dev meson libcunit1 libcunit1-dev curl wget \ | ||
| protobuf-compiler-grpc libgrpc-dev libgrpc++-dev libunwind-dev libgstreamer1.0-dev \ | ||
| libgstreamer-plugins-base1.0-dev libjsoncpp-dev libyaml-cpp-dev ninja-build \ | ||
| libarchive-dev libxml2-dev liblz4-dev libssl-dev openssl pkg-config git |
| libgstreamer-plugins-base1.0-dev libjsoncpp-dev libyaml-cpp-dev ninja-build \ | ||
| libarchive-dev libxml2-dev liblz4-dev libssl-dev openssl pkg-config git | ||
|
|
||
| pip install jsonref |
| pip install jsonref | ||
|
|
||
| ############################ | ||
| # Install CMake 3.22 or higher (required by CMakeLists.txt) |
| git clone --branch develop https://github.com/rdkcentral/Thunder.git | ||
|
|
||
| # Only clone ralf-utils which is required for libralf (needed by sceneset) | ||
| git clone -b v1.2.0 https://github.com/rdkcentral/ralf-utils.git |
Comment on lines
+5
to
+7
| GITHUB_WORKSPACE="${PWD}" | ||
| ls -la ${GITHUB_WORKSPACE} | ||
| cd ${GITHUB_WORKSPACE} |
Comment on lines
+18
to
+19
| set -x | ||
| set -e |
Comment on lines
+24
to
+28
| - name: Native build | ||
| run: | | ||
| bash -x cov_build.sh | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} |
Comment on lines
+71
to
+76
| git clone --branch R4.4.3 https://github.com/rdkcentral/ThunderTools.git | ||
|
|
||
| # Using R4.4.3 (same as ThunderTools) to avoid version mismatches | ||
| # R4.4.1 has JSONRPC API issues that require patches | ||
| git clone --branch R4.4.3 https://github.com/rdkcentral/Thunder.git 2>/dev/null || \ | ||
| git clone --branch develop https://github.com/rdkcentral/Thunder.git |
| jobs: | ||
| build-sceneset-on-pr: | ||
| name: Build sceneset component in github rdkcentral | ||
| runs-on: ubuntu-latest |
| name: Build sceneset component in github rdkcentral | ||
| runs-on: ubuntu-latest | ||
| container: | ||
| image: ghcr.io/rdkcentral/docker-rdk-ci:latest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.