Reproducible v3.1.1 storage failures
While reviewing the current package (4535ff0), I reproduced these independent issues. I am preparing focused PRs, as requested by the contribution guide.
getMany drops the string key __proto__ on web, native, legacy and Windows paths because assignment invokes the inherited object setter. The key should be an ordinary own property, without changing the result's prototype.- A rejected IndexedDB open produces an unhandled rejection even if the caller catches it. A deletion whose request succeeds but transaction aborts resolves successfully and leaves the transaction rejection unhandled. Reproduced with the actual modules,
idb and an isolated IndexedDB implementation.
AsyncStorageError.nativeError(null) throws a TypeError, an existing AsyncStorageError is thrown instead of returned, and LegacyStorageException is misclassified as UnknownError.- Apple's legacy storage removes a manifest entry after a file-read error and puts failed file writes into its read cache. Compiled actual Objective-C method bodies reproduce both, with synthetic read failures and temporary-directory write failures.
- Windows SQLite code truncates keys/values containing NUL, clears transaction ownership before a failed COMMIT can roll back, and asserts for empty multiGet/multiRemove batches. Actual portable C++ methods/helpers reproduce these against in-memory SQLite; a Windows build has not been performed.
No production/user storage or real credentials were accessed. Proposed fixes preserve the public signatures and successful ordinary-key behavior. Observable corrections will be documented in each PR, especially full-byte Windows strings and transaction failures now rejecting.
Reproducible v3.1.1 storage failures
While reviewing the current package (
4535ff0), I reproduced these independent issues. I am preparing focused PRs, as requested by the contribution guide.getManydrops the string key__proto__on web, native, legacy and Windows paths because assignment invokes the inherited object setter. The key should be an ordinary own property, without changing the result's prototype.idband an isolated IndexedDB implementation.AsyncStorageError.nativeError(null)throws a TypeError, an existing AsyncStorageError is thrown instead of returned, and LegacyStorageException is misclassified as UnknownError.No production/user storage or real credentials were accessed. Proposed fixes preserve the public signatures and successful ordinary-key behavior. Observable corrections will be documented in each PR, especially full-byte Windows strings and transaction failures now rejecting.