[Android] Cannot perform this operation because there is no current transaction

[ball-hayden]

What happened?

Error reporting shows the following message:

Cannot perform this operation because there is no current transaction

Version

1.17.3

What platforms are you seeing this issue on?

• Android
• iOS
• macOS
• Windows
• web

System Information

System:
    OS: macOS 12.1
    CPU: (10) arm64 Apple M1 Pro
    Memory: 614.19 MB / 32.00 GB
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 16.14.0 - /var/folders/cg/cnx9y_d15jq3tw07562by7zw0000gn/T/yarn--1651482100494-0.5048468084106195/node
    Yarn: 1.22.17 - /var/folders/cg/cnx9y_d15jq3tw07562by7zw0000gn/T/yarn--1651482100494-0.5048468084106195/yarn
    npm: 8.4.0 - ~/development/PlayerData/app/node_modules/.bin/npm
    Watchman: 2022.03.14.00 - /opt/homebrew/bin/watchman
  Managers:
    CocoaPods: 1.11.3 - /Users/hayden/.gem/ruby/3.0.2/bin/pod
  SDKs:
    iOS SDK:
      Platforms: DriverKit 21.4, iOS 15.4, macOS 12.3, tvOS 15.4, watchOS 8.5
    Android SDK: Not Found
  IDEs:
    Android Studio: 2021.1 AI-211.7628.21.2111.8309675
    Xcode: 13.3.1/13E500a - /usr/bin/xcodebuild
  Languages:
    Java: 11.0.15 - /usr/bin/javac
  npmPackages:
    @react-native-community/cli: Not Found
    react: ^18.0.0 => 18.0.0
    react-native: 0.66.4 => 0.66.4
    react-native-macos: Not Found
  npmGlobalPackages:
    *react-native*: Not Found

Steps to Reproduce

Unable to reproduce.

[krizzu]

Hey, could you please provide move info? What code you use/when? Do you have repro steps?

[ball-hayden]

Hi @krizzu.

Sorry - we don't have any repro steps at all.
It's something we're seeing occasionally through error reporting (Sentry).

We use RNAsyncStorage alongside apollo-cache-persist, and this tends to be where we're seeing the error reported:

[apollo-cache-persist] Error persisting cache Error: Cannot perform this operation because there is no current transaction.
{
arguments: ["[apollo-cache-persist]","Error persisting cache",{}], 
logger: console
}

Probably not massively interesting, but for context our instanciation of apollo-cache-persist:

import AsyncStorage from '@react-native-async-storage/async-storage';
import { CachePersistor, AsyncStorageWrapper } from 'apollo3-cache-persist';

const cachePersistor = new CachePersistor({
  cache,
  storage: new AsyncStorageWrapper(AsyncStorage),
  debounce: 0,
});
cachePersistor.restore();

Apollo Cache Persist interacts using getItem, setItem, and removeItem, as you would expect:
https://github.com/apollographql/apollo-cache-persist/blob/master/src/storageWrappers/AsyncStorageWrapper.ts

[krizzu]

Are you using Next storage implementation? If not, I might suspect that this would happen if you db would be accessed after Activity is destroyed (app is about to close). We have this code in on host destroy, which was placed there to fix other issue

[ball-hayden]

Are you using Next storage implementation?

I'm not sure what you mean by this - sorry.

[krizzu]

There's this feature to use different driver for storage (Android only, more details here)

[ball-hayden]

Ah, thank you.
No - we're not using that.

[krizzu]

In that case, my suspect would be to what I already said above

I might suspect that this would happen if you db would be accessed after Activity is destroyed (app is about to close). We have this code in on host destroy, which was placed there to fix other issue

Can't really tell why/when apollo does storage flush, but maybe it's on going to background?
That's a tough one, especially without solid repro steps

[ball-hayden]

Yeah - that sounds sensible.
I'll see if I can get a reproduction together.

[WtfLaika]

I have same issue only with react-native-async-storage. I have implemented even next storage, but it didn't help. The way to reproduce is next: try to open and close your app 3-7 times(at startup must be implemented async storage) and you will get Error storing data [Error: Cannot perform this operation because there is no current transaction.]

System info:

 OS: macOS 12.0.1
    CPU: (8) arm64 Apple M1
    Memory: 97.69 MB / 8.00 GB
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 18.2.0 - /var/folders/qy/wpyxmffx3l152qq1hgt2j00m0000gn/T/yarn--1653581044654-0.7297387852884578/node
    Yarn: 1.22.18 - /var/folders/qy/wpyxmffx3l152qq1hgt2j00m0000gn/T/yarn--1653581044654-0.7297387852884578/yarn
    npm: 8.10.0 - /opt/homebrew/bin/npm
    Watchman: 2022.05.16.00 - /opt/homebrew/bin/watchman
  Managers:
    CocoaPods: 1.11.2 - /usr/local/bin/pod
  SDKs:
    iOS SDK:
      Platforms: DriverKit 21.4, iOS 15.5, macOS 12.3, tvOS 15.4, watchOS 8.5
    Android SDK: Not Found
  IDEs:
    Android Studio: 2021.2 AI-212.5712.43.2112.8512546
    Xcode: 13.4/13F17a - /usr/bin/xcodebuild
  Languages:
    Java: 11.0.15 - /usr/bin/javac
  npmPackages:
    @react-native-community/cli: Not Found
    react: 17.0.2 => 17.0.2 
    react-native: 0.65.1 => 0.65.1 
    react-native-macos: Not Found

gradle.properties:

AsyncStorage_useNextStorage=true
AsyncStorage_kotlinVersion=1.6.10
AsyncStorage_next_roomVersion=2.4.2
AsyncStorage_db_size_in_MB=100

[krizzu]

try to open and close your app 3-7 times(at startup must be implemented async storage) and you will get Error storing data [Error: Cannot perform this operation because there is no current transaction.]

Can you please add specific code + where you want it? index.js / App component etc.

[WtfLaika]

try to open and close your app 3-7 times(at startup must be implemented async storage) and you will get Error storing data [Error: Cannot perform this operation because there is no current transaction.]

Can you please add specific code + where you want it? index.js / App component etc.

function LaunchScreen({navigation}: LaunchProps) {
  const dispatch = useDispatch();

  useEffect(() => {
    const clearUserOnFirstRun = async () => {
      try {
        const key = '@first_run_complete';
        const value = await AsyncStorage.getItem(key);
        console.log('value', value);
        if (value !== null) {
        } else {
          await AsyncStorage.setItem(key, '1');
          if (auth().currentUser) {
            await auth().signOut();
          }
        }
      } catch (e) {
        console.log('=== HERE IS AN ERROR === ', e);
      }
    };

    clearUserOnFirstRun();

    setTimeout(() => {
      dispatch(login(navigation));
    }, 100);
  }, [dispatch, navigation]);
return ()
}

[storm2513]

I've added this code to App.js, so it's easily reproduced:

const run = async () => {
  const keys = await AsyncStorage.getAllKeys()
  console.log('KEYS', keys)
  const data = 'x'.repeat(1 * 1024 * 1024) + Math.random()
  AsyncStorage.setItem('test', JSON.stringify({ data }))
  AsyncStorage.setItem('test2', JSON.stringify({ data }))
}

setInterval(() => {
  run()
}, 100)

Quickly closing the app with back button and re-opening it on Android 9 immediately leads to error.

Here is the actual error that is visible in logs before facing with Cannot perform this operation because there is no current transaction.

E/SQLiteLog: (5) database is locked
2022-06-16 15:28:55.715 8918-9012/app E/SQLiteDatabase: Failed to open database '/data/user/0/app/databases/RKStorage'.
    android.database.sqlite.SQLiteDatabaseLockedException: database is locked (code 5 SQLITE_BUSY[5]): , while compiling: PRAGMA journal_mode
        at android.database.sqlite.SQLiteConnection.nativePrepareStatement(Native Method)
        at android.database.sqlite.SQLiteConnection.acquirePreparedStatement(SQLiteConnection.java:1229)
        at android.database.sqlite.SQLiteConnection.executeForString(SQLiteConnection.java:842)
        at android.database.sqlite.SQLiteConnection.setJournalMode(SQLiteConnection.java:490)
        at android.database.sqlite.SQLiteConnection.setWalModeFromConfiguration(SQLiteConnection.java:460)
        at android.database.sqlite.SQLiteConnection.open(SQLiteConnection.java:296)
        at android.database.sqlite.SQLiteConnection.open(SQLiteConnection.java:215)
        at android.database.sqlite.SQLiteConnectionPool.openConnectionLocked(SQLiteConnectionPool.java:705)
        at android.database.sqlite.SQLiteConnectionPool.open(SQLiteConnectionPool.java:272)
        at android.database.sqlite.SQLiteConnectionPool.open(SQLiteConnectionPool.java:239)
        at android.database.sqlite.SQLiteDatabase.openInner(SQLiteDatabase.java:1292)
        at android.database.sqlite.SQLiteDatabase.open(SQLiteDatabase.java:1247)
        at android.database.sqlite.SQLiteDatabase.openDatabase(SQLiteDatabase.java:903)
        at android.database.sqlite.SQLiteDatabase.openDatabase(SQLiteDatabase.java:893)
        at android.database.sqlite.SQLiteOpenHelper.getDatabaseLocked(SQLiteOpenHelper.java:355)
        at android.database.sqlite.SQLiteOpenHelper.getWritableDatabase(SQLiteOpenHelper.java:298)
        at com.reactnativecommunity.asyncstorage.ReactDatabaseSupplier.ensureDatabase(ReactDatabaseSupplier.java:86)
        at com.reactnativecommunity.asyncstorage.ReactDatabaseSupplier.get(ReactDatabaseSupplier.java:112)
        at com.reactnativecommunity.asyncstorage.AsyncStorageModule$2.doInBackgroundGuarded(AsyncStorageModule.java:224)
        at com.reactnativecommunity.asyncstorage.AsyncStorageModule$2.doInBackgroundGuarded(AsyncStorageModule.java:192)
        at com.facebook.react.bridge.GuardedAsyncTask.doInBackground(GuardedAsyncTask.java:36)
        at com.facebook.react.bridge.GuardedAsyncTask.doInBackground(GuardedAsyncTask.java:20)
        at android.os.AsyncTask$2.call(AsyncTask.java:333)
        at java.util.concurrent.FutureTask.run(FutureTask.java:266)
        at com.reactnativecommunity.asyncstorage.SerialExecutor$1.run(SerialExecutor.java:25)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641)
        at java.lang.Thread.run(Thread.java:764)