fix(generator): support path and header bindings - #2281
Merged
Conversation
- Preserve path binding when a parameter also contributes a dynamic header. - Add live regressions and GCVerbose generator/runtime benchmarks. - Isolate analyzer white-box tests from the public analyzer test assembly.
glennawatson
marked this pull request as ready for review
July 26, 2026 18:46
ChrisPulman
approved these changes
Jul 26, 2026
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2281 +/- ##
==========================================
- Coverage 99.98% 99.96% -0.03%
==========================================
Files 191 191
Lines 9927 9945 +18
Branches 1908 1912 +4
==========================================
+ Hits 9926 9942 +16
- Partials 1 3 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix.
What is the new behavior?
Source-generated clients now support using one parameter for both a route placeholder and a dynamic header, including routes mapped with
AliasAs.What is the current behavior?
The generator treats these bindings as mutually exclusive and reports an unmatched route placeholder.
Closes #2280.
What might this PR break?
None expected. Existing single-binding parameters are unchanged.
Checklist
mainbranchAdditional information