fix: consistent note object type in Server Components docs#8475
Open
Ashutosh0x wants to merge 1 commit into
Open
fix: consistent note object type in Server Components docs#8475Ashutosh0x wants to merge 1 commit into
Ashutosh0x wants to merge 1 commit into
Conversation
Fixes reactjs#6933 The Server Components docs page had inconsistent handling of the note variable across 3 code examples. All examples now consistently treat note as an object with .authorId, .id, and .content properties.
Size changesDetails📦 Next.js Bundle Analysis for react-devThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the Server Components code examples so the
notevariable is consistently treated as an object throughout all 3 examples on the page.Closes #6933
Changes
Client Component example (
without Server Components):useState('')touseState(null)(note is an object, not a string)note.authorId{note}to{note.content}in JSXServer Component example (
with Server Components):{note}to{note.content}in JSXAsync Server Component example:
{note}to<p>{note.content}</p>in JSXWhy
The
noteobject has properties like.authorId,.id, and.content, but was being:''{note}which would show[object Object]This is confusing for developers learning React Server Components.
cc @rickhanlonii @poteto