All-rbitcoin Warnet via shims (Q-68) - #597
Open
rearden-grok[bot] wants to merge 12 commits into
Open
rearden-grok[bot] wants to merge 12 commits into
rearden-grok[bot] wants to merge 12 commits into
Conversation
rearden-grok
Bot
force-pushed
the
harness/warnet-tanks
branch
from
September 18, 2026 03:55
4c3e052 to
cdcb368
Compare
rearden-grok
Bot
changed the title
Store --connect as host strings and parse via ToSocketAddrs so kube-dns and localhost work. Prefer IPv4. Open Q-66 for the follow-on retry slice. Co-authored-by: Cursor <cursoragent@cursor.com>
Remembered addnode/connect hosts redial every 2s after resolve. Incomplete IBD at genesis with --connect still enters tip-follow so a late peer attaches. Closes Q-66. Co-authored-by: Cursor <cursoragent@cursor.com>
Conf rpcbind=0.0.0.0 and listen=1 (no -bind) bind the proxy and P2P all-interfaces. BITCOIN_DATA can supply -datadir. TestNode conf stays 127.0.0.1. Co-authored-by: Cursor <cursoragent@cursor.com>
Warnet commander authenticates as user:rpcpassword. The proxy accepts that when the password matches the token, and still accepts the cookie line. Co-authored-by: Cursor <cursoragent@cursor.com>
Helm addnode=tank-N becomes --connect tank-N:18444. In-pod bitcoin-cli uses ~/.bitcoin or BITCOIN_DATA and conf rpcuser/rpcpassword when no cookie. Co-authored-by: Cursor <cursoragent@cursor.com>
Returns wallets already in the in-memory hub (empty list at start). createwallet ignores unknown named keys such as descriptors=True. Co-authored-by: Cursor <cursoragent@cursor.com>
Debian slim copies rbitcoin-node, the Python shims, and Core test_framework. PID 1 is a python3 binary named bitcoind so pidof succeeds. RBITCOIN_LOG_STDOUT tees debug lines for kubectl logs. Co-authored-by: Cursor <cursoragent@cursor.com>
Operator-host kind/Warnet steps for an all-rbitcoin network. Image is rbitcoin-warnet:local; not a musl Release. Co-authored-by: Cursor <cursoragent@cursor.com>
Hostname --connect is stored unresolved, so --connect bad no longer fails parse and would run forever. Keep the CLI refuse pin on --connect=. Co-authored-by: Cursor <cursoragent@cursor.com>
CI fmt failed wrapping the one-line --connect= array. Co-authored-by: Cursor <cursoragent@cursor.com>
Bare -port already listens 0.0.0.0; TestNode extra_conf bind=127.0.0.1 stays loopback. Helm rpcbind=0.0.0.0 only moves the test proxy. Co-authored-by: Cursor <cursoragent@cursor.com>
Q-68 said addnode add stores host strings and resolves each dial, but the remembered set was SocketAddr after one lookup. Keep the original node string so a Warnet tank name that is not in DNS yet is still retried. Unresolved add is not a dial error.
rearden-grok
Bot
force-pushed
the
harness/warnet-tanks
branch
from
September 19, 2026 15:28
cdcb368 to
e421f11
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
addnode/--connecthostnames at dial (localhost, missing port uses the network P2P default) and retry until a live session exists. Incomplete IBD at genesis with--connectstill enters tip-follow. Closes Q-68 (Q-66 is alreadyNodeError::Initon master).rpcbind=0.0.0.0binds the proxy all-interfaces; P2P bind follows Core-like-bind/-port(bare-portis0.0.0.0; TestNodebind=127.0.0.1stays loopback).rpcpasswordseedsrpc.token; proxy still accepts TestNode cookie Basic and alsouser:passwordwhen the password matches the token, then forwards Bearer (TCP is Bearer-only). Confaddnode=becomes--connect host:18444;bitcoin-clidefaults to~/.bitcoin;listwalletdirstub forensure_miner.rbitcoin-warnet:local(Python shim as PID 1 namedbitcoind, Coretest_framework, stdout log tee). Runbook:docs/core-functional.mdWarnet lab. Notcore-functionallabeled (no inventoryrunrow change). Operator-host kind/miner_stdis the remaining acceptance; this VM has no Docker/kind.Rebased onto current
origin/master(Bearer TCP, Core-like listen/bind,NodeError::Init, catalog journeys).Test plan
cargo test -p rbitcoin-net parse_peer_addr_localhost_and_default_port/redial_remembered_*cargo test -p rbitcoin-rpc addnodecargo test -p rbitcoin-test --test integration_multinode addnode_add_retries_until_peer_listens./scripts/core-functional/bitcoind.test.sh./scripts/core-functional/rpc_proxy.test.sh./scripts/core-functional/bitcoin-cli.test.sh./scripts/core-functional/rpc_wallet.test.sh./scripts/core-functional/warnet/Dockerfile.test.shkind load+ 3-tankminer_std.py --interval=10 --mature; all threegetblockcountmatch and are > 0