rpc: testmempoolaccept already-known for active-chain txs - #638
Merged
Merged
Conversation
rearden-grok
Bot
force-pushed
the
rpc/testmempoolaccept-already-known
branch
from
September 19, 2026 14:54
1470fbb to
bb5d5f1
Compare
Contributor
Author
Core mempool_accept.py uses testmempoolaccept(['ff00baar']) → -22. decode_tx_hex still returns -32602 "invalid hex digit" / "tx decode: …". Co-authored-by: Cursor <cursoragent@cursor.com> Co-authored-by: Hero-Gamer <92864860+Hero-Gamer@users.noreply.github.com>
Match decoderawtransaction so sendraw, testmempoolaccept, and submitpackage use Core RPC_DESERIALIZATION for junk hex. Co-authored-by: Cursor <cursoragent@cursor.com> Co-authored-by: Hero-Gamer <92864860+Hero-Gamer@users.noreply.github.com>
Owner row and analog: ['ff00baar'] is TX decode failed; string rawtxs is still rawtxs array required (mempool_accept stays skip). Co-authored-by: Cursor <cursoragent@cursor.com> Co-authored-by: Hero-Gamer <92864860+Hero-Gamer@users.noreply.github.com>
Core mines a sendraw then expects txn-already-known with size=0. Master reports bad-txns-inputs-missingorspent for that confirmed spend; live mempool dups stay txn-already-in-mempool. Co-authored-by: Cursor <cursoragent@cursor.com> Co-authored-by: Hero-Gamer <92864860+Hero-Gamer@users.noreply.github.com>
Look up tip + confirmed-strong before test_accept so a mined spend matches Core (not missingorspent). Mempool dups and archive-only rows keep their existing reject paths. Co-authored-by: Cursor <cursoragent@cursor.com> Co-authored-by: Hero-Gamer <92864860+Hero-Gamer@users.noreply.github.com>
Owner row and CHANGELOG for the Core mempool_accept confirmed-tx needle. Co-authored-by: Cursor <cursoragent@cursor.com> Co-authored-by: Hero-Gamer <92864860+Hero-Gamer@users.noreply.github.com>
Unreleased Fixed for the active-chain vs mempool vs archive reject reasons. Co-authored-by: Cursor <cursoragent@cursor.com> Co-authored-by: Hero-Gamer <92864860+Hero-Gamer@users.noreply.github.com>
rearden-grok
Bot
force-pushed
the
rpc/testmempoolaccept-already-known
branch
from
September 19, 2026 15:07
bb5d5f1 to
1b74096
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
testmempoolacceptreportstxn-already-in-mempoolfor confirmed transactions #628:testmempoolacceptreturnstxn-already-knownfor a tx confirmed on the active chain (tx_fk_by_txid_tip+is_confirmed_strong) beforetest_accept.txn-already-in-mempool. Archive-only afterinvalidateblockis not already-known (re-accept allowed).// #628comments. Master currently reportsbad-txns-inputs-missingorspentfor the mined spend (nottxn-already-in-mempool).Hero-Gamer's seam is kept; this drops the inverted PR story, the extra remine pads, and adds owner docs.
Test plan
cargo test -p rbitcoin-rpc --lib testmempoolaccept_active_known_vs_mempool_vs_archivecargo clippy -p rbitcoin-rpc --all-targets -- -D warningsMade with Cursor