test: one hub for the blocks-only and orphan-tx journey - #787
Merged
Merged
Conversation
Blocks-only relay, forced INVs, the inbound age gate, GetData privacy, and orphan parent fetch were fifteen store opens, most with their own 100-block pad. One node walks them on one chain, relay off and then on. The reorg beat now disconnects a real block instead of calling reorg_reaccept, and relay-on purges what a block confirmed while relay was off. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
testmempoolaccept went dry-run in b6d8b09 and stopped calling it. The blocks-only test that still did is folded into a journey, so nothing calls it. Its removal also puts the remove_for_block rustdoc back on remove_for_block. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
@reardencode I got much better sustained performance on catch up (I'm at 400K now) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
peer_tests.rsunits (item 4 of the journey-fold index) intopeer_blocksonly_and_orphan_tx. That is one regtest hub, one peer book, and one 130-block pad, where before there were fifteen store opens, most with their own 100-block pad.relay@whitelisted peer's tx is kept and INV'd to the other inbound. A type-0 getdata is ignored while the tip block still serves.invalidate_block) instead of callingreorg_reaccept. The relay-off "remove is a no-op" check is now a real block plus the relay-on purge. Peers disconnect throughunregister, which also erases their orphans.MempoolHub::evict_live_txids.testmempoolacceptstopped calling it in b6d8b09, and the folded test was its last caller.TESTING.mdgains the catalog row. The compact journey row now points at this journey for the worker park and park-not-reject logs. The ephemeral-broadcast plan's Red/Verify commands name the journey.Three throwaway mutations in
peer.rseach turn the journey red: noinv_gen_floorcheck, serve every mempool getdata, force-announce ignores feefilter.Test plan
cargo test -p rbitcoin-net --lib peer_blocksonly_and_orphan_tx(repeated runs; ~2s)cargo fmt --all -- --check,cargo clippy --workspace --all-targets -- -D warnings,cargo deny check,./scripts/ast-grep.sh,cargo test --workspace --quiet,./scripts/ci-os-smoke.shqc,test,windows,macos,coverage🤖 Generated with Claude Code