index: seal filters and tweaks as IBD connects them - #800
Merged
Merged
Conversation
Indexes enabled before a block is connected append on the confirm write thread. Startup seals a restart gap of at most one write drain with the same window reader; a larger gap still materializes after catch-up. Both paths share one filter-script rule, one height wave, and one commit. Co-authored-by: Cursor <cursoragent@cursor.com>
rearden-grok
Bot
force-pushed
the
index/ibd-append
branch
from
September 28, 2026 15:38
9b58b4f to
1688979
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--block-filter-indexor--sp-tweaksis on before a block is connected, the confirm write thread appends that index afterconfirmed[h]is set. Filters and tweaks are assembled from the wire block and the batch's parent pins, one height per scripts-pool claim.read_index_window, then the new batch is appended. A larger gap is left alone during IBD.rbtc-idx-wbstill runs at tip entry only when a watermark is behind the tip, andNODE_COMPACT_FILTERSis advertised immediately when filters already cover the tip.ibd: perfrecordsidx_asm=on the scripts stage andidx_put=on the write stage.tip: accept bf=stays the sum of those two.Test plan
basic_filter_from_window/tweak_records_from_window, and both watermarks sit at the tip.build_indexes_released.idx_asm=andidx_put=show up, and there is no post-syncindex: buildfrom 0.Made with Cursor