[CodeQuality] Skip nested value compare in CallbackSingleAssertToSimplerRector#718
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CallbackSingleAssertToSimplerRectorconverts acallback()closure with a soleassertSame()into anequalTo()matcher. ButequalTo()matches against the whole closure argument, so the conversion is only correct when the asserted value is the plain closure parameter.When the assert compares a nested value (e.g.
$args['label']), converting toequalTo()would wrongly match the entire argument. Now skipped.Stays untouched (previously wrongly collapsed to
->with($this->equalTo('Test Label'))).Still converts when the actual value is the whole parameter: