[sutaakar]

deploy-rhoai hardcoded the opendatahub namespace even though it applies the rhoai kustomization render directly (kubectl apply -k), which takes its namespace from the kustomization. After rendering into redhat-ods-applications, the target created and labeled the wrong namespace, placed the prometheus-k8s discovery Role/RoleBinding in the wrong namespace, and waited for the deployment in the wrong namespace.

Use APPLICATIONS_NAMESPACE consistently in deploy-rhoai/undeploy-rhoai and default it to redhat-ods-applications to match the manifests.

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
Fixes #

Checklist:

• Docs included if any changes are user facing

[github-actions]

🎉 Welcome to the Kubeflow Trainer! 🎉

Thanks for opening your first PR! We're happy to have you as part of our community 🚀

Here's what happens next:

• If you haven't already, please check out our Contributing Guide for repo-specific guidelines and the Kubeflow Contributor Guide for general community standards.
• Our team will review your PR soon! cc @kubeflow/kubeflow-trainer-team

Join the community:

• Slack: Join our #kubeflow-trainer Slack channel.
• Meetings: Attend the Kubeflow AutoML and Training Working Group bi-weekly meetings.

Feel free to ask questions in the comments if you need any help or clarification!
Thanks again for contributing to Kubeflow! 🙏

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: Organization UI
• Review profile: CHILL
• Plan: Enterprise
• Run ID: 30c07223-5efc-4e8c-bd2e-cf17167b1fbc

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

_{Comment @coderabbitai help to get the list of available commands.}

[ckhordiasma]

@sutaakar: The following test has Failed:

Test Results

4 passed, 6 failed, 0 skipped

View test details

Test	Result	Duration
[BeforeSuite]	✅ PASS	0.001176175s
[It] TrainJob e2e when Creating TrainJob to perform the PyTorch workload should create TrainJob with PyTorch runtime reference	❌ FAIL	600.758218965s
[It] TrainJob e2e when Creating TrainJob to perform OpenMPI workload should create TrainJob with DeepSpeed runtime reference	❌ FAIL	600.124788374s
TestDefaultTrainingHubRuntimesMatchDefaultClusterRuntimes	✅ PASS	0.030000s
TestRunTrainJobWithDefaultClusterTrainingRuntimes	❌ FAIL	6.300000s
TestKubeflowSdkKueueIntegration	❌ FAIL	0.140000s
TestKueueWorkloadPreemptionSuspendsTrainJob	❌ FAIL	0.130000s
TestKueueSchedulingReachesTrainJobPods	❌ FAIL	0.120000s
TestJobSetWorkflow	✅ PASS	176.850000s
TestKubeflowSdk	✅ PASS	114.720000s

OCI Artifact Browser URL

View in Artifact Browser

Inspecting Test Artifacts Manually

To inspect your test artifacts manually, follow these steps:

1. Install ORAS (see the ORAS installation guide).
2. Download artifacts with the following commands:

mkdir -p oras-artifacts
cd oras-artifacts
oras pull quay.io/opendatahub/odh-ci-artifacts:odh-pr-test-trainer-xgzvf

[sutaakar]

/test

[sutaakar]

/test