Skip to content

Use latest release trainer image in param.env - #332

Merged
sutaakar merged 1 commit into
red-hat-data-services:mainfrom
sutaakar:image-bump
Oct 23, 2026
Merged

sutaakar merged 1 commit into
red-hat-data-services:mainfrom
sutaakar:image-bump

Conversation

@sutaakar

Copy link
Copy Markdown
Collaborator

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
Fixes #

Checklist:

  • Docs included if any changes are user facing

@github-actions

Copy link
Copy Markdown

🎉 Welcome to the Kubeflow Trainer! 🎉

Thanks for opening your first PR! We're happy to have you as part of our community 🚀

Here's what happens next:

  • If you haven't already, please check out our Contributing Guide for repo-specific guidelines and the Kubeflow Contributor Guide for general community standards.
  • Our team will review your PR soon! cc @kubeflow/kubeflow-trainer-team

Join the community:

Feel free to ask questions in the comments if you need any help or clarification!
Thanks again for contributing to Kubeflow! 🙏

@coderabbitai

coderabbitai Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Enterprise
  • Run ID: 22d4f8d5-de03-46aa-a9df-e82f8355150c
📥 Commits

Reviewing files that changed from the base of the PR and between a929b91 and 05d3a1e.

📒 Files selected for processing: 1
  • manifests/rhoai/params.env

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

📝 Walkthrough

The RHOAI manifest updates the trainer controller image to the RHOAI 3.6 image. It removes CUDA, ROCm, and CPU training image entries and universal-workbench aliases for versions 3.4 and 3.5.

Changes: RHOAI manifest

Layer / File(s) Summary
Update trainer image settings
manifests/rhoai/params.env
The trainer controller image changes to quay.io/rhoai/odh-trainer-rhel9:rhoai-3.6. The CUDA, ROCm, and CPU training image entries and universal-workbench aliases for versions 3.4 and 3.5 are removed.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Suggested reviewers: chughshilpa

Merge Risk: ⚪ Minimal · up to 05d3a

The manifest update is limited to the intended trainer image and legacy entry removals, with no merge-blocking risk identified.

Pre-merge checks: Passed 4 · Inconclusive 1

Failed Failed checks: 1 inconclusive

Check name Status Explanation Resolution
Description check Inconclusive The description contains only the default template and does not explain the trainer image update or removed image entries. Add a brief summary of the trainer image update and the removed image entries.
Passed Passed checks: 4 passed
Check name Status Explanation
Title check Passed The title clearly identifies the main change: updating param.env to use the latest trainer image.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@ckhordiasma

Copy link
Copy Markdown

@sutaakar: The following test has Failed:

OCI Artifact Browser URL

View in Artifact Browser

Inspecting Test Artifacts Manually

To inspect your test artifacts manually, follow these steps:

  1. Install ORAS (see the ORAS installation guide).
  2. Download artifacts with the following commands:
mkdir -p oras-artifacts
cd oras-artifacts
oras pull quay.io/opendatahub/odh-ci-artifacts:odh-pr-test-trainer-ldwnp

@sutaakar

Copy link
Copy Markdown
Collaborator Author

/test

@sutaakar
sutaakar merged commit 960c37e into red-hat-data-services:main Oct 23, 2026
16 of 20 checks passed
@sutaakar
sutaakar deleted the image-bump branch October 23, 2026 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants