Skip to content

fix: migrate docker-publish from Docker Hub to GHCR - #39

Closed
fcostaoliveira wants to merge 3 commits into
masterfrom
fix/migrate-docker-to-ghcr
Closed

fcostaoliveira wants to merge 3 commits into
masterfrom
fix/migrate-docker-to-ghcr

Conversation

@fcostaoliveira

Copy link
Copy Markdown
Collaborator

Summary

  • Replaces Docker Hub credentials (DOCKER_USERNAME / DOCKER_PASSWORD) with GHCR (ghcr.io) using the built-in GITHUB_TOKEN — no external secrets needed.
  • Updates docker-publish-master.yml, docker-publish-release.yml, and docker-build-pr.yml to target ghcr.io/redis-performance/pubsub-sub-bench.
  • Removes the pre-flight "Check Docker Hub credentials" step that was hard-failing on stale secrets.
  • packages: write permission was already present in the publish workflows; retained throughout.

Files changed

  • .github/workflows/docker-publish-master.yml
  • .github/workflows/docker-publish-release.yml
  • .github/workflows/docker-build-pr.yml

Test plan

  • Merge and verify a test push to master triggers Docker Publish - Master and successfully pushes to ghcr.io/redis-performance/pubsub-sub-bench
  • Confirm no Docker Hub secrets are referenced anywhere in the updated workflows

@github-actions

Copy link
Copy Markdown

Docker Build Validation

Docker build successful!

Platforms tested:

  • linux/amd64 (built and tested)
  • linux/arm64 (build validated)

Git SHA: 65f7a92c45d5cfc2a6be2d87393b8a422ff74288

Tests performed:

  • Help command execution
  • Version output validation
  • Multi-platform build validation

The Docker image is ready for deployment!

@fcostaoliveira

Copy link
Copy Markdown
Collaborator Author

Closing — registry migration is not the right fix. Stale Docker Hub secret will be updated directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants