Repository navigation
Waive cluster bus port protection for servers that support it (with tests) - #573
Conversation
Redis now refuses to start a cluster node with tls-cluster disabled unless cluster-bus-port-protected-mode is explicitly set to no. No benchmark sets tls-cluster, so every remote oss-cluster run failed at startup with only a ping timeout to show for it. - Servers that predate the config abort on it as an unknown directive, so the remote spin-up greps the binary the DB host will run for the config name and only passes --cluster-bus-port-protected-mode no when it is there. - The waiver goes ahead of configuration-parameters: redis-server keeps the last value of a repeated option, so a benchmark's explicit setting still wins. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Add unit tests for the waiver argument (absent by default, an explicit spec value still comes last) and for the remote probe's exit-status handling, extract the remote probe into a helper that warns on SSH/path failures, and apply the same support check to spin_up_local_redis_cluster. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
@paulorsousa @fcostaoliveira could you review? The 8.12 RC1 benchmarks (redis-ref pointing at unstable) fail at cluster startup on |
|
🤖 Automated first-pass review. A human maintainer still needs to review this before merge. LGTM. Here's what I checked:
A few non-blocking notes:
The description says the Nice fix, with good test coverage of the probe edge cases. |
- local probe: catch OSError on open/read (permission denied, directory on PATH) and fall back to no waiver, so run-local no longer aborts and the docstring's "unresolvable counts as unsupported" contract holds - remote probe: shlex.quote the redis-server binary, so a remote_redis_server_path with spaces or shell metacharacters no longer makes the probe fail and silently drop the waiver - reword the remote probe warning: execute_remote_commands raises on SSH connect failures before any exit status, so a non-0/1 status means the binary was not found or unreadable - add regression tests for the unreadable binary and the quoted path - bump version 0.12.40 -> 0.12.41 for release Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
fcostaoliveira
left a comment
There was a problem hiding this comment.
Applied the first-pass review follow-ups in 668af23 (OSError fallback in the local probe, shlex.quote in the remote probe, clearer warning text, plus regression tests) and bumped to 0.12.41 for release. LGTM.
Builds on #572 (@Itzikvaknin), whose commit is kept as-is at the base of this branch.
Problem
Recent Redis refuses to start a non-TLS cluster node unless
cluster-bus-port-protected-modeis set tono. Benchmarks that build Redis fromunstable(--redis-server-binary/redis_ref) fail at cluster startup. The fatalerror goes to stdout and leaves an empty logfile. Servers that predate the directive
abort on it, so it can't be passed unconditionally.
Approach (from #572)
The remote cluster path probes the redis-server binary for the directive name and passes
--cluster-bus-port-protected-mode noonly when the binary contains it. The flag goesbefore
configuration_parameters, so an explicit value in a spec still wins.What this PR adds on top
spin_up_local_redis_cluster(run-local) had the same startup failure. It now passesthe waiver when the local binary contains the directive.
remote_binary_supports_cluster_bus_port_protected_mode.It logs a warning when the probe exit status is neither 0 (found) nor 1 (not found),
for example an SSH failure or a missing binary. In that case it falls back to no waiver.
the local binary check, and the remote probe's handling of exit statuses 0, 1, 2 and -1.
Notes
directive is recognised.
tests/test_defaults_purpose_built_env.py::test_dry_run_*fail on the base commit aswell, and
tests/test_compare.pyfails at collection there. These are unrelated tothis change.
🤖 Generated with Claude Code