Repository navigation
RS: allow_modules_upload - #4502
Merged
Merged
Conversation
Contributor
Contributor
🧠 Redis MemoryFound 10 related items from repository history (5 new this commit):
Memory updated at 9772ca7 |
dwdougherty
approved these changes
Nov 6, 2026
dwdougherty
left a comment
Collaborator
There was a problem hiding this comment.
Just the one comment. LGTM otherwise.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Low Risk
Documentation-only changes with no runtime or API behavior modifications in this diff.
Overview
Documents that custom user-defined module uploads are disabled by default and must be temporarily enabled via the cluster setting
allow_modules_upload(usingPUT /v1/cluster) before either uploadPOSTendpoint will succeed.The user-defined modules REST API page now includes a prominent note with links to the cluster object and update request, states that uploads return
403withmodules_upload_disabledwhile disabled, and lists 403 Forbidden in the status tables forPOST /v2/modules/user-definedandPOST /v2/local/modules/user-defined/artifacts. Recommended security practices adds a cluster-security bullet to enable uploads only during maintenance and turn the flag off again afterward, because custom modules run as native code on nodes.Reviewed by Cursor Bugbot for commit 9772ca7. Bugbot is set up for automated code reviews on this repo. Configure here.