Repository navigation
CI, GitHub Pages, and contributor templates - #11
Merged
Merged
Conversation
Keep MAPPO/QMIX out of tree as a checklist item so PRs stay gym-scoped. Co-authored-by: Cursor <cursoragent@cursor.com>
Replace the old python-app workflow so PRs lint, test, and compile the site, and main publishes Pages. Co-authored-by: Cursor <cursoragent@cursor.com>
Document that ruff, fast pytest, and Sphinx -W are the merge bar. Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced Sep 20, 2026
elprofesoriqo
commented
Sep 20, 2026
elprofesoriqo
left a comment
Collaborator
Author
There was a problem hiding this comment.
Reviewed CI / templates (3 commits). Merge last; then set Pages source to GitHub Actions.
Looks good
- PRs build Sphinx HTML as a
docs-htmlartifact;maindeploys Pages. - Contributor checklist tells people not to vendor MAPPO/QMIX.
Should fix
.github/ISSUE_TEMPLATE/config.yml"Research backlog" points atRESEARCH.mdonmain, which does not exist. Usedocs/research.md(404 otherwise).
Notes (non-blocking)
ci.ymlstill runsruff check .on the whole simulator. Localscripts/verify_all.shdoes the same. That will fail on pre-existing files until ruff is scoped or the old tree is cleaned.- CI
pytest tests/is the full suite; the local script uses-m fast. Call that out or align them.
elprofesoriqo
commented
Sep 20, 2026
| url: https://reforcemind.github.io/NetForge_RL/ | ||
| about: Getting started, Arena, questions, API. | ||
| - name: Research backlog | ||
| url: https://github.com/reforcemind/NetForge_RL/blob/main/RESEARCH.md |
Collaborator
Author
There was a problem hiding this comment.
This URL 404s: there is no RESEARCH.md at the repo root. Point at docs/research.md (or drop the contact link).
Unindent the evaluate command in the docstring and construct FrameRecorder before asserting empty save. Co-authored-by: Cursor <cursoragent@cursor.com>
Ruff 0.16 treats a bare ignore list as a much larger rule set, which fails on the existing simulator files. Co-authored-by: Cursor <cursoragent@cursor.com>
Quote style is single, including fenced examples and the figure builder. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ci.yml: ruff, pytest, Sphinx HTML artifact.docs.ymldeploys GitHub Pages on push tomain.scripts/verify_all.sh/verify_local.ps1.Test plan
docs-htmldocs.ymldeploys https://reforcemind.github.io/NetForge_RL/ onmainChecklist
Stacked on the Sphinx docs PR. Retarget to
mainafter that merges. Enable Pages: Settings → Pages → Source → GitHub Actions.