This repository was archived by the owner on Oct 13, 2026. It is now read-only.
Repository navigation
fix(ui): keep the timeline's total when filtering, drop empty diff lines, use --mono - #4
Merged
Merged
Conversation
…nes, use --mono - Timeline count: the filter path called timelineView.setData(filtered) through updateAll(), which made the filtered set the total. With one chip off, the count read "10 of 10 events"; after None it read "0 of 0". The timeline now takes the full set only on load, and a filter through applyFilter, so the count reads "10 of 12". - Wording changes: a first-seen sentence has no "before" and a removed one has no "after", and each printed an empty − or + line. That was 2 of 10 lines on the sample data; they are no longer printed. - RevertClusterDisplay, DiffView and CertaintyTimeline asked for var(--font-mono), which is defined nowhere, so their labels fell back to the body face. The token is --mono. - lint-staged: biome ignores Markdown and YAML and exits non-zero when every path it is handed is ignored, so any commit touching only a .md file failed the pre-commit hook. Both globs now pass --no-errors-on-unmatched. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EpGaiBuSk5nCSV2hKyD6PN
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the four defects that #3 found but left out of scope.
Changes
applyFilters()calledtimelineView.applyFilter(filtered), thenupdateAll(filtered), which calledtimelineView.setData(filtered)again.applyFilter. The count reads "10 of 12" and "0 of 12".RevertClusterDisplay,DiffViewandCertaintyTimelineusedvar(--font-mono), which is defined nowhere, so their labels fell back to the body face. They now use the stylesheet's--mono..mdfile failed the hook. Both lint-staged globs now pass--no-errors-on-unmatched, which is the same fix nextconsensus-site uses.Checks
bun run lint,tsc --noEmit,bun run test,bun run buildandbun run assets:checkall pass.The same Chromium script was run against main and against this branch at 1440×900:
The commit went through the fixed hook. Running
lint-stagedon a Markdown-only staged change now exits 0; on main it exits 1.🤖 Generated with Claude Code
https://claude.ai/code/session_01EpGaiBuSk5nCSV2hKyD6PN
Generated by Claude Code