Skip to content

fix(deu) - fix contract details validation by using the new way to render fields - #1268

Merged
gabrielseco merged 1 commit into
mainfrom
use-contracts-new-validation-for-deu
Aug 25, 2026
Merged

fix(deu) - fix contract details validation by using the new way to render fields#1268
gabrielseco merged 1 commit into
mainfrom
use-contracts-new-validation-for-deu

Conversation

@gabrielseco

@gabrielseco gabrielseco commented Aug 25, 2026

Copy link
Copy Markdown
Collaborator

I believe some of the fields weren't appering, I was try to fix with other ways but at the moment the correct fix seems this one

https://www.loom.com/share/657587c57341414db91b2be04bd23581?focus_title=1&muted=1&from_recorder=1

I have the loom rambling about it, showing what was happening etc

Note

Low Risk
Single-country onboarding routing change with no auth or data-layer impact; behavior mirrors existing FRA/ITA handling.

Overview
Germany (DEU) is now treated like FRA and ITA for onboarding contract details, so those steps use the jsfVersion 1 path (useContractDetailsSchema with per-field state) instead of useJSONSchemaForm.

This aligns DEU with how wage portage and APL countries already render and validate contract details, addressing incorrect validation when DEU was on the generic JSON Schema form path.

Reviewed by Cursor Bugbot for commit 95cd85c. Bugbot is set up for automated code reviews on this repo. Configure here.

@gabrielseco gabrielseco self-assigned this Aug 25, 2026
@github-actions

Copy link
Copy Markdown
Contributor

📦 Bundle Size Report

Metric Current Previous Change Status
Total (gzip) 257.48 kB 257.48 kB +2 B (+0.0%) 🔴
Total (raw) 689.62 kB 689.62 kB +6 B (+0.0%) 🔴
CSS (gzip) 21.69 kB 21.69 kB 0 B (0%) 🟢
CSS (raw) 112.77 kB 112.77 kB 0 B (0%) 🟢

Size Limits

  • ✅ Total gzipped: 257.48 kB / 350 kB (73.6%)
  • ✅ Total raw: 689.62 kB / 850 kB (81.1%)
  • ✅ CSS gzipped: 21.69 kB / 25 kB (86.8%)

Largest Files (Top 5)

  1. chunk-AUPAAQUT.js - 14 kB (0 B (0%))
  2. styles.css - 10.85 kB (0 B (0%))
  3. index.css - 10.85 kB (0 B (0%))
  4. index.js - 6.78 kB (+1 B (+0.0%))
  5. chunk-VNMUML3T.js - 6.55 kB (0 B (0%))
View All Files (417 total)
File Size (gzip) Change
chunk-AUPAAQUT.js 14 kB 0 B (0%)
styles.css 10.85 kB 0 B (0%)
index.css 10.85 kB 0 B (0%)
index.js 6.78 kB +1 B (+0.0%)
chunk-VNMUML3T.js 6.55 kB 0 B (0%)
chunk-CM4TDUW6.js 6.43 kB new
chunk-EGR672LT.js 5.66 kB new
chunk-C4HFMTSB.js 5.33 kB 0 B (0%)
chunk-7HGU72GB.js 4.65 kB 0 B (0%)
chunk-G3KQCVQQ.js 4.22 kB new

✅ Bundle size check passed

@github-actions

Copy link
Copy Markdown
Contributor

📊 Coverage Report

⚪ Coverage unchanged

Metric Current Previous Change Status
Lines 85.42% 85.42% 0%
Statements 84.98% 84.98% 0%
Functions 83.56% 83.56% 0%
Branches 76.89% 76.89% 0%

Detailed Breakdown

Lines Coverage
  • Covered: 4300 / 5034
  • Coverage: 85.42%
  • Change: 0% (0 lines)
Statements Coverage
  • Covered: 4373 / 5146
  • Coverage: 84.98%
  • Change: 0% (0 statements)
Functions Coverage
  • Covered: 1144 / 1369
  • Coverage: 83.56%
  • Change: 0% (0 functions)
Branches Coverage
  • Covered: 2682 / 3488
  • Coverage: 76.89%
  • Change: 0% (0 branches)

✅ Coverage check passed

@github-actions

Copy link
Copy Markdown
Contributor

Deploy preview for adp-cost-calculator ready!

Project:adp-cost-calculator
Status: ✅  Deploy successful!
Preview URL:https://adp-cost-calculator-8be1t9bvo-remotecom.vercel.app
Latest Commit:95cd85c

Deployed with vercel-action

@github-actions

Copy link
Copy Markdown
Contributor

Deploy preview for remote-flows ready!

Project:remote-flows
Status: ✅  Deploy successful!
Preview URL:https://remote-flows-jyyh3u33v-remotecom.vercel.app
Latest Commit:95cd85c

Deployed with vercel-action

@gabrielseco
gabrielseco merged commit 1b87e83 into main Aug 25, 2026
11 checks passed
@gabrielseco
gabrielseco deleted the use-contracts-new-validation-for-deu branch August 25, 2026 12:17
@gabrielseco gabrielseco mentioned this pull request Aug 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants