fix(deu) - fix contract details validation by using the new way to render fields - #1268
Merged
Merged
Conversation
…lidate/render fields
Contributor
📦 Bundle Size Report
Size Limits
Largest Files (Top 5)
View All Files (417 total)
✅ Bundle size check passed |
Contributor
📊 Coverage Report⚪ Coverage unchanged
Detailed BreakdownLines Coverage
Statements Coverage
Functions Coverage
Branches Coverage
✅ Coverage check passed |
Contributor
|
Deploy preview for adp-cost-calculator ready!
Deployed with vercel-action |
Contributor
|
Deploy preview for remote-flows ready!
Deployed with vercel-action |
jordividaller
approved these changes
Aug 25, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I believe some of the fields weren't appering, I was try to fix with other ways but at the moment the correct fix seems this one
https://www.loom.com/share/657587c57341414db91b2be04bd23581?focus_title=1&muted=1&from_recorder=1
I have the loom rambling about it, showing what was happening etc
Note
Low Risk
Single-country onboarding routing change with no auth or data-layer impact; behavior mirrors existing FRA/ITA handling.
Overview
Germany (DEU) is now treated like FRA and ITA for onboarding contract details, so those steps use the jsfVersion 1 path (
useContractDetailsSchemawith per-field state) instead ofuseJSONSchemaForm.This aligns DEU with how wage portage and APL countries already render and validate contract details, addressing incorrect validation when DEU was on the generic JSON Schema form path.
Reviewed by Cursor Bugbot for commit 95cd85c. Bugbot is set up for automated code reviews on this repo. Configure here.