Repository navigation
chore(release): prepare v0.1.0 - #13
Merged
Merged
Conversation
"Auto-lock after" and "Clear the clipboard after" are type="number" inputs, and the webview drew its own spin buttons on them: unthemed, and crowding the w-20 field. NumberRow now sets appearance:textfield on the input and appearance:none on its -webkit-inner-spin-button and -webkit-outer-spin-button, the pseudo-elements WebKit and Chromium draw. No Tauri webview is Gecko, so there is no -moz- rule. The field stays type="number": min, max, the spinbutton role and ArrowUp/ArrowDown stepping are unchanged, and commit still clamps to 0..=max. Closes #10
extension/test/sites.md made every release tag wait on a 15-minute live-site run, a hand check of the sites it reported blocked, and two real-app sign-ins. Subclave has one user, so that is more process than it needs: an autofill bug gets fixed when it shows up. sites.md, sites.spec.ts (which read its Sites table), sites.config.ts and the test:sites script are deleted, along with the spec's testIgnore entries and the release step and CI carve-out in SUBCLAVE.md. The specs CI runs are unchanged. CHANGELOG.md: [0.1.0] is dated 03-10-2026. CONTRIBUTING.md: the CI list gains pnpm typecheck:extension, which the frontend job runs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Release prep for v0.1.0: the live-site autofill checklist is gone, the
CHANGELOG section is dated, CONTRIBUTING's CI list is complete, and the
spin buttons on the two Settings > Security number fields are hidden.
Why
Closes #10.
The checklist in
extension/test/sites.mdmade every release tag wait on a15-minute live-site run, a hand check of the sites it reported blocked, and
two real-app sign-ins. Subclave has one user, so that is more process than it
needs: an autofill bug gets fixed when it shows up.
How
sites.md,sites.spec.ts(which read its Sites table),sites.config.tsand thetest:sitesscript are deleted, along with thespec's
testIgnoreentries inextension/test/playwright.config.ts, the"Before the tag" step and the CI carve-out in
SUBCLAVE.md. Nothing elseused the spec's helpers, so no support code goes with it. The specs CI runs
are unchanged.
CHANGELOG.md:[0.1.0]is dated 03-10-2026. No Fixed lines for Settings > Security: the number fields' spin buttons clash with the theme #10 orfix(sync): add the conditional-write switch to the join screen #11, since neither fix touches a released version.
CONTRIBUTING.md: the CI list gainspnpm typecheck:extension, which thefrontend job runs between
tsc --noEmitandpnpm build.NumberRowinsrc/settings/sections/SecuritySection.tsx):the input gets
[appearance:textfield]plusappearance-noneon::-webkit-inner-spin-buttonand::-webkit-outer-spin-button. Tailwind v4has no
textfieldutility, so it is an arbitrary property. No-moz-rule:no Tauri webview is Gecko. The field stays
type="number", somin/max,the spinbutton role and ArrowUp/ArrowDown stepping are unchanged, and
commitstill clamps to0..=max. Nothing replaces the buttons.Testing
pnpm run lint:imports,pnpm run typecheck:scripts,pnpm run format:check,pnpm run verify(17/17),pnpm exec tsc --noEmit,pnpm run typecheck:extension,pnpm build.pnpm --filter subclave-extension test: 83 tests in 5 files, all green.The built CSS carries all three rules:
::-webkit-inner-spin-button{-webkit-appearance:none;appearance:none}, thesame for
::-webkit-outer-spin-button, andappearance:textfield.Chromium (Playwright), with the built CSS and the field focused and hovered:
a control input without the new classes shows the up/down arrows, and the
patched one shows only its value.
WebKitGTK's MiniBrowser under Xvfb rendered a black window every time, so
WebKit is not tested.
node scripts/release-notes.mjs v0.1.0prints the 0.1.0 section and themacOS footer.
pnpm exec tsc --noEmitcleanManual smoke-test of the affected feature
(If you touched
src-tauri/)cargo checkclean(If UI) tested in
pnpm tauri:dev(isolated dev data dir)No changes under
src-tauri/. Not tested inpnpm tauri:devyet, nor in theapp on macOS (WKWebView) or Windows (WebView2).
Screenshots / GIFs
None attached. The only visual change is that the two fields lose their spin
buttons.
Notes for reviewer
d38e1fb:42 yes, 1 no, 7 blocked) stay in history at
d814683.