Repository navigation
Conversation
#17) * test(extension): settle the two flaky fill.spec popup tests Both failures were races in the tests, not in the extension. openPopup loaded popup.html in a tab that was active at the time, and the tests brought the fixture to the front only afterwards. The popup's first get-state answers for the active tab, and chrome.tabs.query hides the url of a chrome-extension:// tab, so a get-state that ran first got "No active page" and the popup never listed an option. openPopup now takes the page under test and brings it to the front before popup.html loads, so the popup loads in a background tab and its first get-state sees that page. generateAndFill fills the page before it calls save-login, so a log read taken as soon as #password held the generated value could run before the fake app had logged save-login. Both generate tests now wait for the popup's "Password saved to Subclave" notice, which shows only after save-login has answered. Closes #15 * feat(release): attach the extension zips to the draft release A tagged release shipped only the desktop installers, so getting the extension meant building it from source or fetching a CI artifact that expires after 7 days. The new publish-extension job runs after create-release. It builds the chrome and firefox targets, zips them with the same commands as CI's extension job, and uploads subclave-chrome.zip and subclave-firefox.zip into the draft by release_id, as tauri-action does: a re-run creates a second draft for the same tag, so a lookup by tag could pick the wrong one. It needs no Rust toolchain and no proxy build. README.md gains an install section: Load unpacked on Chromium browsers, with the pinned ID fbefjngeldidlcdilbigapddeimhklpn and the manual update, and on Firefox a temporary add-on on release and Beta or a file install with signatures off on ESR, Developer Edition and Nightly. KNOWN-LIMITS.md records the manual install and update; SUBCLAVE.md's release workflow mentions the zips. Closes #16
Version 0.1.1 everywhere it is set, and CHANGELOG.md holds the dated [0.1.1] section in place of [0.1.0].
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Merges
devintomainfor v0.1.1.Why
Tagging
v0.1.1onmainruns.github/workflows/release.yml, which buildsthe signed updates, the extension zips and a draft GitHub Release with notes
from the
[0.1.1]section ofCHANGELOG.md.Included:
fill.spec.tspopup tests settled
How
Merge commit, not squash, so
dev's history lands onmainunchanged.main's only commit not ondevis the v0.1.0 merge commit, whose tree isdev's at that point, so the merge has nothing to resolve: its tree isdev's head tree.Testing
CI passed all seven checks on chore(release): prepare v0.1.1 #18, whose tree is the current
devhead:frontend, rust, extension, and the macOS arm64, macOS x64, Linux x64 and
Windows x64 bundles. The push run on feat(release): ship the extension zips and settle two flaky fill tests #17's merge into
devpassed allseven too.
node scripts/release-notes.mjs v0.1.1prints the 0.1.1 section and themacOS footer.
The version is 0.1.1 in
package.json,extension/package.json,src-tauri/tauri.conf.json,src-tauri/Cargo.toml,src-tauri/subclave-proxy/Cargo.tomland both extension manifests.pnpm exec tsc --noEmitcleanManual smoke-test of the affected feature
(If you touched
src-tauri/)cargo checkclean(If UI) tested in
pnpm tauri:dev(isolated dev data dir)CI covers the two checked boxes. This PR adds no code of its own.
Screenshots / GIFs
None. No UI change.
Notes for reviewer
date moved first.
publish-extensionupload step runs for the first time on this tag.