Repository navigation
Conversation
…row (#21) When the page's host has no entries of its own but other hosts of the domain do, the picker's last row now opens the toolbar popup through the service worker (`inline-open-popup`, `chrome.action.openPopup`). It fills nothing and releases nothing, so it needs a trusted click but not the six guards. Where the popup cannot open, the footer turns into text naming the Extensions menu and the `fill-login` shortcut for the rest of the page. Closes #20.
…gion (#23) The join screen was a fixed 384px column that scrolled on its own, so the wheel worked only over that column. The eye button's addon in PasswordField hung 3px past its input group, and the scrolling form turned that into a horizontal scrollbar. The screen is now the scroll container and the form is m-auto up to max-w-3xl, the Settings content width. The addon overrides pr-3 has-[>button]:-mr-1 with pr-2 has-[>button]:mr-0, so the button stays where it was and nothing hangs past the group. Join vault no longer requires an S3 Region. provider_config passes the region through as typed, Settings > Sync saves it blank, and a server that takes an empty one works with it (Cloudflare R2 reads it as auto). Bucket stays required for S3: a blank one builds {endpoint}//{key} paths. connectionFieldsReady becomes missingConnectionFields, which returns the labels of the blank fields, and useMasterPassword also returns problems, one sentence per rule the password still fails. useJoinSync builds blockers from both, the credential pair and the passphrase, and derives canSubmit from it. The screen lists the blockers under the button in muted text. scripts/sync-verify.ts checks the new connection gate, including the blank Region. Closes #22
Version 0.2.0 everywhere it is set, and CHANGELOG.md holds the dated [0.2.0] section in place of [Unreleased] and [0.1.1].
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Merges
devintomainfor v0.2.0.Why
Tagging
v0.2.0onmainruns.github/workflows/release.yml, which buildsthe signed updates, the extension zips and a draft GitHub Release with notes
from the
[0.2.0]section ofCHANGELOG.md.Included:
How
Merge commit, not squash, so
dev's history lands onmainunchanged.main's only commits not ondevare the v0.1.0 and v0.1.1 merge commits,and the v0.1.1 one's tree is
dev's at #18, so the merge has nothing toresolve: its tree is
dev's head tree.Testing
CI passed all seven checks on chore(release): prepare v0.2.0 #24, whose tree is the current
devhead:frontend, rust, extension, and the macOS arm64, macOS x64, Linux x64 and
Windows x64 bundles. The push run on fix(vault): let the join form follow the window and accept a blank Region #23's merge into
devpassed too.node scripts/release-notes.mjs v0.2.0prints the 0.2.0 section and themacOS footer.
The version is 0.2.0 in
package.json,extension/package.json,src-tauri/tauri.conf.json,src-tauri/Cargo.toml,src-tauri/subclave-proxy/Cargo.tomland both extension manifests.pnpm exec tsc --noEmitcleanManual smoke-test of the affected feature
(If you touched
src-tauri/)cargo checkclean(If UI) tested in
pnpm tauri:dev(isolated dev data dir)CI covers the two checked boxes. This PR adds no code of its own.
Screenshots / GIFs
None. The UI changes are in #21 and #23, and neither has screenshots.
Notes for reviewer
date moved first.
Chrome 127 or later and in Firefox, the join screen in
pnpm tauri:devonWebKitGTK, and a join against a real R2 bucket with Region blank.