feat: add trimSilence option to control sox silence trimming - #8
Open
Dror-Kaufman wants to merge 1 commit into
Open
feat: add trimSilence option to control sox silence trimming#8Dror-Kaufman wants to merge 1 commit into
Dror-Kaufman wants to merge 1 commit into
Conversation
Removes leading silence trimming when set to false. Fixes truncated recordings on WSL where PulseAudio startup delay causes sox to clip initial speech. Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
sox's
silence 1 0.1 1%parameter removes leading silence from recordings, but it can sometimes clip the first word or two.Solution
Add a
trimSilenceoptional parameter (defaulttrue) that keeps the original behavior. Allow setting it tofalseto omit the silence parameter from the sox command, preserving the full recording from the start.This behavior / issue was observed on WSL.