docs: fix GitHub token regeneration attribution in Terraform proxy flow - #4311
Merged
Merged
Conversation
…y flow The step-4 description attributed regenerating the fresh GitHub token to the proxy-registry worker. The worker validates the JWT and receives the installation credentials from the Replicated API's session endpoint, which is where the fresh, short-lived token is actually minted server-side. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
✅ Deploy Preview for replicated-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for replicated-docs-upgrade ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
github-actions
Bot
added
type::docs
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Corrects the step-4 description of the Terraform proxy registry download flow on the Include Terraform Modules page.
Why
The doc attributed regenerating the fresh GitHub token to the proxy-registry worker. In the actual implementation, the worker validates the JWT and calls the Replicated API's session endpoint, and it is the API that regenerates the fresh, short-lived GitHub token server-side and returns the installation credentials to the worker. The worker only uses those credentials to fetch and stream the tarball.
This matters for anyone reasoning about the trust boundary: the token is minted server-side in the API, not at the edge worker.
Evidence
proxy-registry/src/terraform.ts(getTerraformSession→ usessession.githubToken)handlers/vendor-api/replv3/proxy/get_terraform_session.goThe end-state the doc describes (fresh, short-lived, server-side, never exposed to the customer) is unchanged and remains accurate. This is a wording/attribution fix only.
🤖 Generated with Claude Code