Repository navigation
Add evidence-preserving context packing and governed Memory packet adapter - #22
Conversation
Retain protected records, paired tool calls and dependency closures within an actual JSON byte budget. Add explicit host bindings, omission manifests, Memory source revalidation, 52 offline regression tests, and a synthetic demo. No model calls, automatic hooks, transcript edits or authority changes.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 446f9958f5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Validation update at
|
jmborden1112-beep
left a comment
There was a problem hiding this comment.
LGTM
Needs Fixing
None. Reviewed context packing preserves protected constraints, provenance and explicit partial coverage. The governed Memory adapter rechecks host-controlled authorization and current source before and after assembly. The refresh incorporates the already-reviewed Windows cleanup fix from merged PR25.
Requires Human Review
None beyond the repository approval gate fulfilled here under the owner's second-account authorization. This is agent source review, not independent human sign-off.
Recommended Optional
None.
Create Follow-up Issue
None.
Workflow Trace: exact head1b5e00d9d63ee0c6e3c2b290702de78e514ef021; /root/fable_stack_review source lenses plus root verification, gpt-6-luna medium fallback. Refreshed local npm test174passed/3platformskips/0failed; real pinned Memory producer contract gate, Node/PowerShell package validators, and diff check pass. All eight refreshed-head CI checks pass, including packed artifact and Windows/POSIX matrices. No model calls, native compaction qualification, publication or user-plugin activation is claimed.
Current-head review and validation — October 3, 2026
Exact head:
c652d12a49749fcef54b7555ca0da002528c01dd; current main:154bf0b220566d91d1a4aaf4390d9c3a54926c3a.Independent read-only review completed all nine changed files and the relevant imports/callers, covering budget/dependency preservation, evidence and source binding, CLI I/O, the Memory adapter and package inclusion. No actionable source defect remained. This is a source-review result, not the repository's required approving GitHub review.
node --test test/context-pack.test.mjs— 58 passed, 0 failed, 0 skipped.node scripts/validate-memory-context-pack.mjs <PINNED_MEMORY_CHECKOUT>— passed and verified producer blob79ab8f628c003ec2834b4de09ed7f42ed4d53c53. Result-count and byte-cap cases retain selected=3, emitted snippets=1 and omitted=2. No Memory database, model or network was used.8b78ae4d02f9478337065061cb9e24c5bcae0d5fhas the same tracked tree as the reviewed branch. Full matrix tests: Ubuntu/macOS 176 passed + 1 platform skip; Windows 175 passed + 2 platform skips; zero failures.git diff --checkpassed; the isolated review checkout remained clean. No CI rerun or source edit was needed.All review conversations are resolved. The selected_chunks concern is refuted by the pinned actual producer and executed integration gate; the earlier Unicode, symlink-entrypoint and sparse-array findings have corrections and focused regressions at this head.
Required independent GitHub approval remains missing. Merge this PR normally before retargeting #23 to actual main; #25's independent Windows fixes remain preserved. Current tests do not qualify native Codex compaction/resume, real host Memory integration or token/task-quality savings.
Workflow trace: parent refreshed heads/base/protection/CI and owns record updates; worker
/root/fable_ecf_reviewcompleted the source/caller review and targeted validation, read-only with no recursive delegation. The original author validation and single-agent trace below remain historical.Summary
Implements the requested Fable context-packing augmentation on top of merged Laya PR #21. Working Node library/CLI, an adapter for Memory's inspected context-mode packet, executable synthetic demo, and regression tests—not only a design scaffold.
pack/verify; bounded regular-file reads; no transcript discovery, model/API call, file mutation, Codex launch or configuration changes.packReviewedMemoryuses current host authorization/source-verification callbacks before and after verification, preserves required evidence refs, and never writes Memory or promotes completion evidence.Preservation
Existing six skills, catalog, coordinator/worker models, wrappers, approval boundaries, Laya behavior, package/plugin versions, release claims, root marketplace and Actions workflow are unchanged. No native compaction replacement or automatic hook is installed. Source-only addition, not part of tagged alpha.2.
Validation performed
Local Node 22.16.0 on Linux:
node --test test/context-pack.test.mjs: 52 passed, 0 failed, 0 skipped.Coverage includes protected kinds, dependencies and cycles, pair integrity, Unicode byte limits, scope/head/policy/revision mismatches, digest tampering, incomplete upstream coverage, Memory denial/revocation, and actual CLI execution from an unrelated working directory.
Validation limitations
Container GitHub DNS failed, so a full checkout was unavailable. Current main, repository instructions, package validator and relevant source contracts were read through the GitHub connector. The full existing suite, PowerShell wrapper, packed-artifact gate and OS/Node matrix were not run locally; hosted checks must pass at this exact head before merge. No real Memory/context-mode/Codex process, native compaction/resume or resumed-task quality was evaluated. No token/cost/quality improvement is claimed.
The Memory adapter uses the inspected packet shape and controlled callbacks in tests. Real production ECF/source verification remains the trusted host's responsibility. The pure packer checks supplied bindings rather than querying live permissions. Neither packing nor pinning sanitizes prompt injection or renews historical approval.
Try it
Read
docs/context-packing.mdfor the contract, privacy/retention boundary and integration requirements.Sources
Original Agoragentic MIT code; selective-retention design inspiration from https://github.com/tamaratran/fast-jev-compaction . No upstream code, hosted transport, replay policy or Claude hook was imported.
Memory
bridge.cjsblob inspected:79ab8f628c003ec2834b4de09ed7f42ed4d53c53.Official Codex hooks reviewed: https://developers.openai.com/codex/hooks . Post-compaction
SessionStartcontext is documented; replacing the message list viaPreCompactis not.Workflow Trace
Single-agent multi-lens: source compatibility; evidence/authority; data/privacy; executable correctness; packaging. No real subagents available. No merge, deployment, registry publication, dependency installation, paid call or user configuration mutation. A separately reviewable standalone OSS Codex package will build on this core.