Skip to content

fix: repair Windows launchers, evaluation guards, commit binding and safe sync - #28

Merged
rhein1 merged 4 commits into
mainfrom
codex/fable-audit-repairs-20261020
Oct 21, 2026
Merged

rhein1 merged 4 commits into
mainfrom
codex/fable-audit-repairs-20261020

Conversation

@rhein1

@rhein1 rhein1 commented Oct 20, 2026 •

Copy link
Copy Markdown
Owner

Scope and verified repair

Repairs the four post-merge audit findings against main a2aa9efc3b04cdc924ac9620f050db530760faf0:

  • One launcher descriptor binds version/catalog/execution, including npm-only Windows and explicit overrides without command-shell or policy bypass.
  • Requirement-level false completion and fabricated/wrong citations independently fail noncompensatory safety guards; expected slots remain fixed.
  • Evaluation inputs execute from bounded exact Git-object exports, not clean-status assertions. The fresh pre-merge audit also reproduced a replacement-ref bypass; final head disables replacement objects on identity/status/tree/blob reads and tests both commit and blob replacement refs.
  • Personal sync checks path components, verifies staged content, retains the previous package and restores an unambiguously absent target after promotion failure.

Reuses PR27 supplied-record accounting without upgrading RECORDS_SATISFIED into independently observed work. Issue24 matching, frozen graders, leakage controls, full denominators, unknown-cost handling and disabled promotion remain in place.

Final head and validation

Final head: 9974059ecd338b0527180c8b2aa7acff3ca555ed.

  • Source and installed-tarball suites each: 377 total,373 pass,4 explicit platform skips,0 failures. Package and PowerShell validators pass.
  • All8 final-head hosted checks pass: six OS/Node matrix jobs, packed artifact and Release gate.
  • New independent read-only pre-merge audit found no scoped blocker;32 focused tests pass. Automated/cloud technical review at this exact head completed with no findings; none of this is independent human GitHub approval.
  • The plugin payload is unchanged from qualified231977d; installed source/cache still match all79 tested Windows files. Windows/Linux native install/upgrade/rollback/fresh-skill discovery checks succeeded for that payload. Existing desktop chats are not claimed reloaded.

Comparison and limits

The six-trial comparison remains attributed to 231977d, not relabeled as a new9974059 run. The only later change is the harness replacement-ref binding fix, not the plugin payload. Both arms scored1.0; recorded child time was66.008s/75.573s and reported tokens192279/244174 (baseline/candidate). No actual routed-model attestation, all-in cost proof, representative private holdout or superiority claim. Effectiveness/cost admissibility/promotion remain false; historical packets were not rewritten or regraded.

Sync path checks assume no hostile concurrent local filesystem races; physical junction qualification is not inferred from mocked tests. Inventory covers content/path/type rather than every platform attribute. Occupied targets are never recursively removed for rollback; configuration backups remain separate.

The owner has authorized this merge and an explicitly disclosed administrative approval through the existing second account controlled by the same solo maintainer. This is not an independent second human review, and branch protection is not changed or bypassed. No release, npm/directory publication, deployment, paid activation or security-setting mutation is authorized here.

@rhein1
rhein1 marked this pull request as ready for review October 21, 2026 00:20
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-21T00:22:52.036599Z 9974059 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@jmborden1112-beep jmborden1112-beep left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Owner-authorized administrative approval for exact head 9974059. This account and the PR author are controlled by the same solo maintainer; this is NOT an independent second-human review. Independent automated technical audit found no scoped blockers (32 focused tests); final source/packed suites each have373 passes and4 visible skips; all8 hosted checks pass. The owner explicitly authorized this existing second-account approval and merge. No branch protection or security setting is changed or bypassed. Supplied-record accounting, observed execution, installation and effectiveness remain distinct.

@rhein1
rhein1 merged commit 0e6a42d into main Oct 21, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants