Load example data from rheodata instead of bundling it - #32
Merged
Merged
Conversation
- Add rheopy-rheodata>=0.1 as a dependency; example/walkthrough datasets now come from the rheodata package (single source of truth). - Delete bundled data: rheofit/data/*.json, *.xlsx and docs/walkthrough/*.json (PNGs/SVGs kept). - Walkthrough docs load data via rheodata.to_rheofit(); all documented fit numbers verified to reproduce exactly from rheodata. - demo_source() materializes the Carbopol demo dataset from rheodata (no network needed; data ships in the rheodata wheel); CLI --demo and the skill demo flow keep working. Drop DATA_DIR/DEMO_JSON_FILE. - Skill demo reworked around the rheodata Carbopol dataset (tc vs HB).
…walkthrough rheodata 0.1.1 ships the linear polymer amplitude and frequency sweeps, so the narrative-only sections become runnable code: load both sweeps via rheodata.load(), compute |eta*(w)| and eta'(gamma0*w), and compare against the flow curve with log-RMS on the overlap range. All documented numbers reproduce (Carreau 3.847e-03, Cox-Merz 2.3 %, Delaware-Rutgers 9 %); verified end-to-end plus sphinx build with no new warnings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rheofit no longer bundles example data — it loads it from the
rheodatapackage (pip install rheopy-rheodata), now live on PyPI at v0.1.0. One source of truth for data.What changed
rheopy-rheodata>=0.1added topyproject.toml.rheofit/data/*.json,rheofit/data/*.xlsx(4 files) anddocs/walkthrough/*.json(3 files). All PNGs/SVGs indocs/walkthrough/kept.rheodata.to_rheofit(...):walkthrough.md→caggioni_pg_carbopol_2pct/carbopol_2pct(CLI block replaced with the Python API; reproducibility now viaseed=0)walkthrough-carreau.md→caggioni_linear_polymer_flow/linear_polymer(flow-curve fit executable; amplitude/frequency sweeps from the same session remain in the comparison figures — those datasets are not in rheodata v0.1.0 yet)walkthrough-carreau-carreau.md→caggioni_wlm_polymer_temp_series/T_18…walkthrough-carbopol-glycerin.md→caggioni_carbopol_glycerin_temp/T_20,T_30,T_40(also fixes the stale 0/1/2 step indices — sample IDs are explicit now)demo_source()materializes the Carbopol demo dataset from rheodata as a TRIOS JSON in the temp dir — still no network needed (data ships in the rheodata wheel). CLI--demoand the skill demo flow keep working.DATA_DIR/DEMO_JSON_FILEremoved;DEMO_SAMPLE_NAMEis now"Carbopol 2% in PG (demo)".rheofit/skills/and.github/skills/copies): demo section rewritten around the rheodata Carbopol dataset (tc vs HB head-to-head); also drops the dead P&G SharePoint fallback URL.demo_source()description updated.Verification
pip installof the branch pullsrheopy-rheodatafrom PyPI;import rheofitworks.python -m rheofit --demo(print_steps + tc fit) works on the materialized demo.sphinx-build -W -b html docs docs/_build/html: clean for all touched pages (only pre-existingmyst.xref_missingwarnings for the WASM explorer iframes, which are generated byexport_interactive.pyin CI).Follow-up (not in this PR): add the linear-polymer amplitude/frequency sweeps to rheodata so the Carreau walkthrough is fully executable again.