Consume rheological models from rheomodel (1.1.0) - #34
Open
marcocaggioni wants to merge 1 commit into
Open
marcocaggioni wants to merge 1 commit into
marcocaggioni wants to merge 1 commit into
Conversation
The nine model modules in rheofit/models/ are now thin adapters: equations, parameters, bounds, citations and the model ladder come from rheomodel; only the fitting hooks (initial_guess, seed_from_parent, fit_model) stay in rheofit. Adds the rheopy-rheomodel>=0.1 dependency and bumps to 1.1.0.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the vendored model definitions from rheofit: the nine modules in
rheofit/models/are now thin adapters that import equations, parameters,bounds, the nesting ladder and citations from
rheomodel. Only the fittinghooks (
initial_guess,seed_from_parent,fit_model) stay in rheofit;_fitcore.pyis untouched (_func = equationalias).Also: adds
rheopy-rheomodel>=0.1to dependencies, bumps to 1.1.0(public API unchanged), updates the README layout,
docs/conf.py, andboth skill copies (new-model workflow now starts in rheomodel).
Verification
and notes bit-identical at
fasteffort; tc + herschel_bulkley alsoidentical at
normaleffortskipped interactive-export step)
Note:
rheopy-rheomodelis not on PyPI yet (trusted publisher notconfigured), so installs/CI depending on it will fail until the v0.1.0
release publishes.