Repository navigation
Fit app: fix data-section display (marimo branch-expression) - #46
Merged
Merged
Conversation
marimo only renders a cell's last expression when it is not nested inside a branch, so the Data/Step/Sample vstacks inside if/else never displayed. Restructure: decide what to show, then one unnested display expression at the end of the cell. Verified with `marimo check` (clean).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The upload/data-source section never rendered:
marimo checkflags it —marimo only displays a cell's last expression when it is not nested
inside an if/else branch, so the
mo.vstack(...)calls inside theData and Step/Sample cells' branches were silently dropped.
Restructured both cells: decide what to show in the branches, then a
single unnested
mo.vstack(...)display expression at the end.marimo checkis clean; data-path logic re-verified headlessly.Also saved a short marimo-notebook skill locally (
workspace/skills/marimo-notebook/) so the pattern sticks.