Skip to content

test(transaction): add comprehensive transaction mode and advanced feature tests #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vistart merged 3 commits into from
Apr 8, 2026
Merged

test(transaction): add comprehensive transaction mode and advanced feature tests #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8e6eef2
test(transaction): add comprehensive transaction mode and advanced fe…
vistart Apr 7, 2026
477e289
fix(transaction): respect PostgreSQL optional syntax for BEGIN statement
vistart Apr 8, 2026
c067f9f
chore: add changelog fragment for PR #20
vistart Apr 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/20.fixed.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fixed PostgreSQL transaction manager to respect optional BEGIN syntax - isolation level is no longer forced, allowing SESSION CHARACTERISTICS to take effect when not explicitly set.
12 changes: 8 additions & 4 deletions src/rhosocial/activerecord/backend/impl/postgres/transaction.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,10 @@ def __init__(self, backend: "PostgresBackend", logger=None):
logger: Optional logger instance.
"""
super().__init__(backend, logger)
# PostgreSQL default isolation level is READ COMMITTED
self._isolation_level = IsolationLevel.READ_COMMITTED
# PostgreSQL default isolation level is READ COMMITTED, but we don't
# set it here to allow SESSION CHARACTERISTICS to take effect.
# Users can explicitly set isolation_level property if needed.
# self._isolation_level = None (inherited from base class)
# DEFERRABLE mode for SERIALIZABLE transactions
self._is_deferrable: Optional[bool] = None
# Deferred constraints list
Expand Down Expand Up @@ -196,8 +198,10 @@ def __init__(self, backend: "AsyncPostgresBackend", logger=None):
logger: Optional logger instance.
"""
super().__init__(backend, logger)
# PostgreSQL default isolation level is READ COMMITTED
self._isolation_level = IsolationLevel.READ_COMMITTED
# PostgreSQL default isolation level is READ COMMITTED, but we don't
# set it here to allow SESSION CHARACTERISTICS to take effect.
# Users can explicitly set isolation_level property if needed.
# self._isolation_level = None (inherited from base class)
# DEFERRABLE mode for SERIALIZABLE transactions
self._is_deferrable: Optional[bool] = None
# Deferred constraints list
Expand Down
Loading
Loading