[vistart]

Description

Refactors SQL function generation utilities by migrating them from types/ to functions/ directory, following the module responsibility separation principle.

Changes:

• functions/text_search.py (new): Contains 14 text search functions (to_tsvector, to_tsquery, plainto_tsquery, phraseto_tsquery, websearch_to_tsquery, ts_matches, ts_matches_expr, ts_rank, ts_rank_cd, ts_headline, tsvector_concat, tsvector_strip, tsvector_setweight, tsvector_length)
• functions/xml.py (new): Contains 4 XML functions (xmlparse, xpath_query, xpath_exists, xml_is_well_formed)
• types/text_search.py: Removed functions, retained types (PostgresTsVector, PostgresTsQuery, etc.)
• types/xml.py: Removed functions, retained types (PostgresXML)

Affected Files:

• functions/text_search.py (new)
• functions/xml.py (new)
• functions/init.py (updated exports)
• types/text_search.py (functions removed)
• types/xml.py (functions removed)
• types/init.py (removed function exports)
• backend/init.py (updated import sources)
• tests (updated imports)

Type of change

• refactor: A code restructuring without behavior change
• feat: A new feature
• docs: Documentation only changes
• perf: A code change that improves performance
• test: Adding missing tests or correcting existing tests
• chore: Changes to the build process or auxiliary tools
• ci: Changes to our CI configuration files and scripts
• build: Changes that affect the build system or external dependencies
• revert: Reverts a previous commit

Breaking Change

• No
• Yes

Applicable rhosocial-activerecord Version Range:

Related Repositories/Packages

• python-activerecord (core package): Backend module import source changed
• python-activerecord-testsuite: Tests using postgres backend may need import updates

Testing

• I have added new tests to cover my changes.
• I have updated existing tests to reflect my changes.
• All existing tests pass.
• This change has been tested on [specify backend/DB versions].

Test Plan:

• Verified with testsuite (1011 tests passed)
• Test branch: postgres fix/move-functions-from-types vs core release/v1.0.0.dev20

Checklist

• My code follows the project's code style guidelines.
• I have performed a self-review of my own code.
• I have commented my code, particularly in hard-to-understand areas.
• I have made corresponding changes to the documentation (Docstrings, README.md, etc.).
• My changes generate no new warnings.
• I have added a Changelog fragment (changelog.d/<issue_number>.<type>.md).
• I have verified that my changes do not introduce SQL injection vulnerabilities.
• I have checked for potential performance regressions.

Additional Notes

• Changelog fragment will be created after PR merge (internal type)
• Test results: 1011 tests passed

[codecov]

Codecov Report

❌ Patch coverage is 49.43820% with 45 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.73%. Comparing base (408ac6b) to head (cd0674b).
⚠️ Report is 1 commits behind head on release/v1.0.0.dev10.

Files with missing lines	Patch %	Lines
...ord/backend/impl/postgres/functions/text_search.py	26.66%	44 Missing ⚠️
...ctiverecord/backend/impl/postgres/functions/xml.py	96.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@                   Coverage Diff                    @@
##           release/v1.0.0.dev10      #24      +/-   ##
========================================================
+ Coverage                 72.71%   72.73%   +0.02%     
========================================================
  Files                       119      121       +2     
  Lines                      6860     6867       +7     
  Branches                   1139     1139              
========================================================
+ Hits                       4988     4995       +7     
  Misses                     1470     1470              
  Partials                    402      402              

Flag	Coverage Δ
postgres-18	72.73% <49.43%> (+0.02%)	⬆️
python-3.14	72.73% <49.43%> (+0.02%)	⬆️
unittests	72.73% <49.43%> (+0.02%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud