Repository navigation
Conversation
…greSQL Add PostgresAlterColumnModifierMixin so PostgreSQL emits the vendor qualifiers supported since 9.6: ADD COLUMN IF NOT EXISTS, DROP COLUMN IF EXISTS, and DROP CONSTRAINT IF EXISTS, opt-in via if_not_exists / if_exists on AddColumn / DropColumn / DropTableConstraint. Wire the mixin into PostgresDialect ahead of TableMixin/ConstraintMixin and add the supports_drop_constraint_if_exists capability to PostgresConstraintSupport and PostgresConstraintMixin. Add unit tests covering qualifier and plain forms.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PostgreSQL has supported the vendor
IF [NOT] EXISTSqualifiers onALTER TABLEsince 9.6. This PR addsPostgresAlterColumnModifierMixinso the backend emits:ADD COLUMN IF NOT EXISTSDROP COLUMN IF EXISTSDROP CONSTRAINT IF EXISTSThey are opt-in via
if_not_exists/if_existsonAddColumn/DropColumn/DropTableConstraint;None(default) renders the plain SQL-standard form.Also adds the
supports_drop_constraint_if_existscapability toPostgresConstraintSupport/PostgresConstraintMixin.Requires the core
python-activerecordPR #114 (new qualifier fields on the ALTER TABLE actions).