Repository navigation
Fix Mission Control passthrough on macOS 27 - #6
Merged
Merged
Conversation
Contributor
|
I think yours is the first repo I've ever been listed as a contributor on! Appreciate it Riley and have a good one bossman |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On macOS 27, Mission Control can expose a single Dock window at layer 20 with no layer-18 window. Strafe currently misses that layout and intercepts swipes that should stay native. Recognize it on macOS 27+, retaining the existing detection rule on earlier systems.
This adopts the small window-layer check from @Ozdotdotdot's PR #2 (original commit 2b75106). Ozair remains the author of the adapted code commit, with Riley credited as co-author. The full PR #2 engine rewrite remains unmerged.
Validation: reproduced the missed detection on macOS 27.0, verified detection while Mission Control is open and reset after closing, and confirmed the new C regression fails before the fix and passes afterward. Strict Swift build, all four Swift tests, C sanitizer tests, release bundle, and signature verification passed locally.
Also records the security review of PRs #2, #4, and #5 in docs/reviews/2026-09-17-contributions.md. No evidence of malicious additions was found in those reviewed revisions; outstanding correctness issues and review limitations are documented.