Add filter options menu to QuickFilterView and ComboQuickFilterView (#2230) by RealAhmedKhairi · Pull Request #3582 · rizinorg/cutter

RealAhmedKhairi · 2026-03-21T04:36:21Z

I've read the guidelines for contributing to this repository
I made sure to follow the project's coding style
I've used AI tools to generate fully or partially these code changes and I'm sure the changes are not copyrighted by somebody else.
I've updated the documentation with the relevant information (if needed)

Detailed description
Previously, there was no way to filter quick searches. Users had no menu to toggle certain settings when searching. I have added this menu in QuickFilterView and ComboQuickFilterView widgets as requested in #2230.
I have read SearchBarWidget to understand the requirements of the issue and started working right after, The menu I have created is a line-edit menu instead of creating a separate button. I have achieved this using QLineEdit::addAction() as advised by one of the maintainers.

Changes Made

src/widgets/QuickFilterView.h: Added member variables, new signal, and helper method
src/widgets/QuickFilterView.cpp: Implemented menu creation and filter logic
src/widgets/ComboQuickFilterView.h: Same additions for consistency
src/widgets/ComboQuickFilterView.cpp: Same implementation for consistency

References

Inspired by how SearchBarWidget handles filter options
Referenced Qt documentation: https://doc.qt.io/qt-6/qlineedit.html#addAction
Uses SearchOption enum from src/common/CutterSearchable.h
Code follows Cutter's coding style guidelines

Test Plan

Open Cutter and load a binary
Verify the cog icon appears
- Look for a small cog/settings icon on the LEFT side of the filter text input
- The icon should be inside the line-edit, not outside
Click the cog icon
- A dropdown menu should appear with 3 options:
  - ☐ Case Sensitive
  - ☐ Exact Match
  - ☐ Regular Expression
Test toggling options
- Click each option to toggle the checkbox
- Verify the checkbox state changes visually
- Try typing in the filter while options are toggled
Verify filtering behavior
- With "Case Sensitive" checked: searches should be case-sensitive
- With "Exact Match" checked: only exact matches should be found
- With "Regular Expression" checked: search should accept regex patterns
Test ComboQuickFilterView (widgets using combo box + filter)
- Repeat steps 2-6 for any widget using ComboQuickFilterView
- Verify same menu behavior

closes #2230.

wargio

you added a lot of useless files. there are even binaries. this is not ok

please follow the instructions on how to build cutter and dont commit llm/ai nonsense

RealAhmedKhairi · 2026-03-22T13:09:16Z

@wargio I have cleaned everything up.

wargio

I feel like the code repeats itself, maybe this could go into a class? @notxvilka what do you think?

PremadeS · 2026-03-25T10:50:54Z

I feel like the code repeats itself, maybe this could go into a class?

Agreed, See #3580 it moves the old duplicate logic in both to a new class

RealAhmedKhairi · 2026-03-27T22:27:44Z

@PremadeS What do I have to do now?

PremadeS · 2026-03-30T14:03:23Z

None of the options work, because there is no logic to handle case sensitive, exact match etc
Please test the PR fully before committing

PremadeS

^

PremadeS · 2026-03-30T14:05:41Z

@PremadeS What do I have to do now?

Keep it as it is, just make sure it works

RealAhmedKhairi · 2026-03-30T17:40:50Z

@PremadeS I am sorry, I have been a little busy with my college midterms. I will start working on the functionality as soon as possible.

PremadeS · 2026-04-07T09:17:44Z

Filter doesn't update according to text unless any option is changed
Also the item count is not working properly

RealAhmedKhairi · 2026-04-13T18:14:28Z

@PremadeS I will start working on making CI green.

PremadeS · 2026-04-13T20:43:24Z

@PremadeS I will start working on making CI green.

It's most likely failing due to #3600

RealAhmedKhairi · 2026-04-14T08:01:36Z

@PremadeS Should I wait until #3600 is merged?

RealAhmedKhairi · 2026-05-09T15:15:57Z

@PremadeS Hi! Can we do anything to finish this pull request since #3600 was merged.

notxvilka · 2026-05-09T20:42:15Z

@PremadeS Hi! Can we do anything to finish this pull request since #3600 was merged.

You need to rebase the PR first - see there are some conflicts.

PremadeS · 2026-05-11T16:07:55Z

@PremadeS Hi! Can we do anything to finish this pull request since #3600 was merged.

1- Resolve conflicts and rebase
2- QuickFilterView and ComboQuickFilterView now inherit from AbstractFilterView due to changes made by #3580 meaning it would be better to put the duplicate logic from both classes in AbstractFilterView

apologies for the late reply, completely slipped my mind

RealAhmedKhairi · 2026-05-11T18:04:47Z

@PremadeS It is okay, I am currently juggling multiple projects at college and will be done by Thursday, thanks for replying and I will surely start working on this PR as soon as I can.

…violations

PremadeS · 2026-06-25T10:14:36Z

    virtual void closeFilter();

 signals:
    void filterTextChanged(const QString &text);


You can remove the filterTextChanged signal now and only use filterChanged

Also you didn't update filters in XRefsDialog

PremadeS

Almost there :)

Just a few minor additions and then it's ready to be merged

PremadeS · 2026-06-26T09:51:36Z

+    auto *optionsMenu = new QMenu(this);
+    caseSensitiveAction = optionsMenu->addAction(tr("&Case Sensitive"));
+    caseSensitiveAction->setCheckable(true);
+
+    wholeWordsAction = optionsMenu->addAction(tr("Exact Match"));
+    wholeWordsAction->setCheckable(true);
+
+    regexAction = optionsMenu->addAction(tr("Regular Expression"));
+    regexAction->setCheckable(true);


If you're going to use the "&" shortcut then you should use them for all three actions, currently it's only being used on "Case sensitive" action

Also, there should be a shortcut key in my opinion that opens the actions menu. Default shortcuts are defined in "shortcuts/DefaultShortcuts.cpp"

PremadeS · 2026-06-26T09:56:01Z

+    auto *optionsMenu = new QMenu(this);
+    caseSensitiveAction = optionsMenu->addAction(tr("&Case Sensitive"));
+    caseSensitiveAction->setCheckable(true);
+
+    wholeWordsAction = optionsMenu->addAction(tr("Exact Match"));
+    wholeWordsAction->setCheckable(true);


This works, but in my opinion there should be options in "Edit->Preferences->Interface" under the "Quick Filter" tab for these three things:

Use case sensitive by default

Match whole words by default

Use regex by default

User preference should be saved, just so that if a user always prefers case sensitive search they don't have to manually change it each time cutter is opened

The actions will be added/handled in "InterfaceOptionsWidget"

* Add option to rename a type * Add option to view and set type class for a type * Fix type usages not being shown * Fix Double clicking on type usage not showing memory widget

Co-authored-by: Anton Kochkov <anton.kochkov@gmail.com>

Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 4 to 8. - [Release notes](https://github.com/actions/download-artifact/releases) - [Commits](actions/download-artifact@v4...v8) --- updated-dependencies: - dependency-name: actions/download-artifact dependency-version: '8' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Fix namespace alias DH conflict with OpenSSL typedef OpenSSL 3.x includes openssl/types.h (via openssl/bn.h pulled in transitively through rizin headers) which declares: typedef struct dh_st DH; This conflicts with the namespace alias: namespace DH = DisassemblyHelper; The C++ standard does not allow a namespace alias and a typedef to share the same identifier in the same declarative region. The compiler resolves DH as the OpenSSL struct, causing build failures when using rizin built with SSL support. Rename the alias from DH to DisHlp to eliminate the collision.

RealAhmedKhairi · 2026-06-27T20:54:33Z

@PremadeS You got it.

…violations

RealAhmedKhairi · 2026-06-28T13:15:58Z

To test the new change: Navigate to Edit -> Preferences -> Interface and choose your preferred default search approaches under the Quick Filter section. The next time you use a search bar, your chosen defaults will automatically be checked in the menu and applied to the search.

wargio requested changes Mar 21, 2026

View reviewed changes

notxvilka added the Requirements not met The PR doesn't meet the minimum contribution requirements. See CONTRIBUTING.md for details. label Mar 21, 2026

RealAhmedKhairi force-pushed the issue2230 branch from b6937ea to 4bf8965 Compare March 22, 2026 12:10

wargio reviewed Mar 25, 2026

View reviewed changes

Comment thread src/widgets/ComboQuickFilterView.cpp Outdated

wargio reviewed Mar 25, 2026

View reviewed changes

Comment thread src/widgets/QuickFilterView.cpp Outdated

wargio requested changes Mar 25, 2026

View reviewed changes

RealAhmedKhairi force-pushed the issue2230 branch from 4bf8965 to 22b6079 Compare March 25, 2026 14:43

PremadeS requested changes Mar 30, 2026

View reviewed changes

RealAhmedKhairi force-pushed the issue2230 branch from 22b6079 to 772df1e Compare April 4, 2026 08:15

wargio reviewed Apr 4, 2026

View reviewed changes

Comment thread build-output.txt Outdated

wargio reviewed Apr 4, 2026

View reviewed changes

Comment thread src/common/CutterSearchable.cpp Outdated

wargio reviewed Apr 4, 2026

View reviewed changes

Comment thread src/common/CutterSearchable.cpp Outdated

RealAhmedKhairi force-pushed the issue2230 branch 2 times, most recently from faa6bc1 to e3f5e62 Compare April 6, 2026 05:51

RealAhmedKhairi force-pushed the issue2230 branch from 4b0a0c1 to 6312258 Compare April 11, 2026 13:32

RealAhmedKhairi force-pushed the issue2230 branch from 6312258 to 8942cc8 Compare May 14, 2026 13:26

RealAhmedKhairi force-pushed the issue2230 branch 5 times, most recently from cd3bd24 to d47e9f8 Compare June 20, 2026 11:54

Refactor filter views to use AbstractFilterView and fix clang-format …

961764f

…violations

RealAhmedKhairi force-pushed the issue2230 branch 7 times, most recently from 8ab910f to 355f5c4 Compare June 24, 2026 13:13

PremadeS requested changes Jun 25, 2026

View reviewed changes

RealAhmedKhairi force-pushed the issue2230 branch from 355f5c4 to 0fbcc9a Compare June 25, 2026 12:22

PremadeS requested changes Jun 26, 2026

View reviewed changes

PremadeS and others added 9 commits June 26, 2026 15:46

Update rizin to latest dev (rizinorg#3624)

873ad17

TypesWidget: Add rename and set typeclass option (rizinorg#3622)

f01659a

* Add option to rename a type * Add option to view and set type class for a type * Fix type usages not being shown * Fix Double clicking on type usage not showing memory widget

Use rizin api for setting fcn calling convention (rizinorg#3616)

bd1c8a5

Add tab in preferences to query/modify rizin evars (rizinorg#3615)

5e56cf0

Update Rizin to the latest dev (rizinorg#3626)

63517fc

Co-authored-by: Anton Kochkov <anton.kochkov@gmail.com>

Update translations (rizinorg#3627)

dfd5fd2

macos_sign.sh: Fix ENOSPC in codesign step (rizinorg#3630)

5209e49

Refactor filter views to use AbstractFilterView and fix clang-format …

bb23643

…violations

RealAhmedKhairi force-pushed the issue2230 branch from d59ccff to bb23643 Compare June 28, 2026 13:12

Merge branch 'dev' into issue2230

fc72708

Uh oh!

Uh oh!

Conversation

RealAhmedKhairi commented Mar 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes Made

References

Test Plan

Uh oh!

wargio left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

RealAhmedKhairi commented Mar 22, 2026

Uh oh!

Uh oh!

Uh oh!

wargio left a comment

Choose a reason for hiding this comment

Uh oh!

PremadeS commented Mar 25, 2026

Uh oh!

RealAhmedKhairi commented Mar 27, 2026 • edited by PremadeS Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

PremadeS commented Mar 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

PremadeS left a comment

Choose a reason for hiding this comment

Uh oh!

PremadeS commented Mar 30, 2026

Uh oh!

RealAhmedKhairi commented Mar 30, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

PremadeS commented Apr 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

RealAhmedKhairi commented Apr 13, 2026

Uh oh!

PremadeS commented Apr 13, 2026

Uh oh!

RealAhmedKhairi commented Apr 14, 2026

Uh oh!

RealAhmedKhairi commented May 9, 2026

Uh oh!

notxvilka commented May 9, 2026

Uh oh!

PremadeS commented May 11, 2026

Uh oh!

RealAhmedKhairi commented May 11, 2026

Uh oh!

PremadeS Jun 25, 2026

Choose a reason for hiding this comment

Uh oh!

PremadeS left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

PremadeS Jun 26, 2026

Choose a reason for hiding this comment

Uh oh!

PremadeS Jun 26, 2026

Choose a reason for hiding this comment

Uh oh!

RealAhmedKhairi commented Jun 27, 2026

Uh oh!

RealAhmedKhairi commented Jun 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

RealAhmedKhairi commented Mar 21, 2026 •

edited

Loading

wargio left a comment •

edited

Loading

RealAhmedKhairi commented Mar 27, 2026 •

edited by PremadeS

Loading

PremadeS commented Mar 30, 2026 •

edited

Loading

PremadeS commented Apr 7, 2026 •

edited

Loading

PremadeS left a comment •

edited

Loading