Fix odd-length hex conversion crash - #3658
Open
atirna wants to merge 2 commits into
Open
Conversation
wargio
reviewed
Aug 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Detailed description
rz_hex_str2binwrites one byte for a trailing lone nibble and returns the byte count as a negative value. The old code only reservedhex.length() / 2bytes, so a single nibble passed an unwritable zero-capacity buffer to Rizin and crashed inrz_hex_str2bin.I resize the buffer to
(length / 2) + 1before conversion, then use the absolute return value as the final byte count. Odd inputs now keep the padded low nibble without writing past the buffer or passing a negative size toQByteArray::resize.I used OpenAI Codex (GPT-5.6 Sol) to inspect the affected conversion path and help verify the change.
Test plan (required)
Cuttertarget against the bundled Rizin submodulehexStringToBytes("e")crashes withSIGBUS(exit 138)6162returns6162,ereturnse0, and61626returns616260xcrun clang-format --dry-run --Werror -style=file src/core/Cutter.cppClosing issues
Closes #3641