Repository navigation
Remove isRegex and close the step object at format 0.9 - #36
Merged
Merged
Conversation
Redactions have superseded isRegex since 0.4: a {{name}} placeholder says
which part of a line varies and why, where a whole-line regular expression
made the line stop reading as the output it stands for. Keeping both meant
two ways to match by pattern, a rule forbidding their combination, and a
step type that could be either.
Nothing has been written against isRegex, so it goes now rather than
waiting for 1.0. While MAJOR is 0 a minor may take something away as well
as add it, which is what 0.x means everywhere else; version.go and the
format doc now say so, and the promise starts at 1.0.
The step object gains additionalProperties: false, without which a script
still carrying isRegex would have been accepted and quietly matched
literally -- reporting success for a comparison it did not make, which is
the one failure this tool must not commit itself. It is now rejected by
name.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019f9gkZVUEo3jtv51GSb4vJ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Redactions have superseded
isRegexsince0.4. Keeping both left two ways to match by pattern, a rule forbidding their combination, and a step type that could be either.Nothing has been written against
isRegex, so it goes now rather than waiting for1.0.What changed
isRegexremoved from the schema, the Go type, and the validator;Step.UsesPattern()andvalidateRegexesare gone with it. Redactions are the only way a step matches by pattern."additionalProperties": false. Without it, a script still carryingisRegexwould have been accepted and quietly matched literally — reporting success for a comparison it did not make. It is now rejected by name:0.9.version.goanddocs/script-format.mdnow state the0.xrule explicitly: while MAJOR is0a minor may take a field away as well as add one, and the additive promise starts at1.0.Verification
make format,make lint,PRESCRIPT_REQUIRE_RUNNERS=1 make test,make build_devandmake examplesall pass; the dice histogram is unchanged.🤖 Generated with Claude Code
https://claude.ai/code/session_019f9gkZVUEo3jtv51GSb4vJ