Skip to content

Name the registry a pulled image came from, not just its digest - #38

Merged
rjnienaber merged 1 commit into
mainfrom
fix/image-digest
Sep 7, 2026
Merged

rjnienaber merged 1 commit into
mainfrom
fix/image-digest

Conversation

@rjnienaber

Copy link
Copy Markdown
Owner

Follow-up to #37, found by running make pull_image against the first published image.

make pull_image gives the pulled image a local tag, and the daemon then reports a repo digest under that short name as well as under the registry one:

prescript-env@sha256:6bd7cc15...
ghcr.io/rjnienaber/prescript-env@sha256:6bd7cc15...

docker/run.sh took the first entry, so $PRESCRIPT_IMAGE named the right bytes under a name nobody else can reach — and a repro line that cannot be pulled is not one.

The registry-qualified entry is now picked out by its hostname rather than by being listed first; a locally built image, which has no repo digests at all, still falls back to its config digest.

Verification

  • pulled: ghcr.io/rjnienaber/prescript-env@sha256:6bd7cc1531480e0140b624d15e808444393df905fc73259e3b8091bddb21983d
  • built by make image: sha256:85c296c14a0bd6494667630bd7772aba6e11e33c20e3d8d28917704c04c27ffb

🤖 Generated with Claude Code

https://claude.ai/code/session_019f9gkZVUEo3jtv51GSb4vJ

`make pull_image` gives the pulled image a local tag, and the daemon then
reports a repo digest under that short name as well as under the registry
one. Taking the first entry got `prescript-env@sha256:...`, which is the
right bytes under a name nobody else can reach -- and a repro line that
cannot be pulled is not one.

The registry-qualified entry is now picked out by its hostname rather than by
being listed first, and a locally built image still falls back to its config
digest.

Verified both ways round: a pulled image reports
ghcr.io/rjnienaber/prescript-env@sha256:6bd7cc..., and one built by `make
image` reports sha256:85c296....

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019f9gkZVUEo3jtv51GSb4vJ
@rjnienaber
rjnienaber merged commit fdaae04 into main Sep 7, 2026
5 checks passed
@rjnienaber
rjnienaber deleted the fix/image-digest branch September 7, 2026 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant