Repository navigation
Name the registry a pulled image came from, not just its digest - #38
Merged
Merged
Conversation
`make pull_image` gives the pulled image a local tag, and the daemon then reports a repo digest under that short name as well as under the registry one. Taking the first entry got `prescript-env@sha256:...`, which is the right bytes under a name nobody else can reach -- and a repro line that cannot be pulled is not one. The registry-qualified entry is now picked out by its hostname rather than by being listed first, and a locally built image still falls back to its config digest. Verified both ways round: a pulled image reports ghcr.io/rjnienaber/prescript-env@sha256:6bd7cc..., and one built by `make image` reports sha256:85c296.... Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019f9gkZVUEo3jtv51GSb4vJ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #37, found by running
make pull_imageagainst the first published image.make pull_imagegives the pulled image a local tag, and the daemon then reports a repo digest under that short name as well as under the registry one:docker/run.shtook the first entry, so$PRESCRIPT_IMAGEnamed the right bytes under a name nobody else can reach — and a repro line that cannot be pulled is not one.The registry-qualified entry is now picked out by its hostname rather than by being listed first; a locally built image, which has no repo digests at all, still falls back to its config digest.
Verification
ghcr.io/rjnienaber/prescript-env@sha256:6bd7cc1531480e0140b624d15e808444393df905fc73259e3b8091bddb21983dmake image:sha256:85c296c14a0bd6494667630bd7772aba6e11e33c20e3d8d28917704c04c27ffb🤖 Generated with Claude Code
https://claude.ai/code/session_019f9gkZVUEo3jtv51GSb4vJ