Repository navigation
fix(avalonia): pass bool x:True for NTFS preset CommandParameter - #2170
Merged
Mbucari merged 1 commit intoNov 18, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2095.
Cause
In
EditReplacementChars.axaml, the three NTFS preset buttons (Defaults,LoFiDefaults,Barebones) passedCommandParameter="True", which XAML evaluates as aSystem.String. BecauseDefaults(bool isNtfs),LoFiDefaults(bool isNtfs), andBarebones(bool isNtfs)take abool, Avalonia's compiled-bindingCommandExecuteTrampolinethrewSystem.InvalidCastException: Unable to cast object of type 'System.String' to type 'System.Boolean'.Fix
Change
CommandParameter="True"toCommandParameter="{x:True}"on those three buttons.Testing
dotnet build Source/LibationAvalonia/LibationAvalonia.csproj --no-restore: 0 warnings, 0 errors.