Repository navigation
fix: clear LicenseDenied deferrals on account re-registration and clarify skip message - #2172
Merged
Mbucari merged 3 commits intoNov 18, 2026
Conversation
…rify skip message
…inExternalOptions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LicenseDenieddeferrals on account re-registration:libationcli login-external),DownloadAttemptFailureStorecould leave the remaining queued titles deferred for ~24 hours even after the user re-authenticated with modern Widevine credentials (as seen in Throttled/content license denied #2140).DownloadAttemptFailureStore.ClearForAccount(string? account, DownloadFailureKind kind), raisedApiExtended.AccountReRegisteredwhen a forced login / re-registration succeeds, wired it inLibationScaffolding.wireUpSystemEvents, and called it fromLoginExternalOptionson forced/re-registration logins.AssetUnavailable(e.g. preorders) and other accounts' deferrals are preserved.BackupRequest:SkipReason.WaitingToRetryfrom"Waiting before trying again after a recent failure"to"Titles waiting to retry after a recent failure"("download a title on its own to try it now") so the trailing: <count>unambiguously refers to the title count rather than a wait duration.Testing
ApplicationServices.Tests: 110 passed, 0 failed (including newClearForAccount_clears_matching_kind_only_for_that_account)LibationUiBase.Tests: 233 passed, 0 failedLibationCli.Tests: 75 passed, 0 faileddotnet build Source/Libation.slnx --no-restore: 0 warnings, 0 errors