Skip to content

fix(ci): stop Windows installer from bundling the build zip - #2173

Open
wtanksleyjr wants to merge 1 commit into
rmcrackan:masterfrom
wtanksleyjr:fix/windows-installer-exclude-zip
Open

wtanksleyjr wants to merge 1 commit into
rmcrackan:masterfrom
wtanksleyjr:fix/windows-installer-exclude-zip

Conversation

@wtanksleyjr

Copy link
Copy Markdown
Contributor

Cause

In .github/workflows/build-windows.yml, the Zip artifact step runs in working-directory: ./bin and wrote the release .zip directly into ./bin/. The subsequent Build Windows installer step passes ./bin as SourceDir to Scripts/Windows/Libation.iss, whose [Files] section uses Source: "*", causing Inno Setup to bundle the .zip of the complete build inside every -setup.exe (doubling installer size and dropping the .zip into the install directory).

Fix

  1. Write the release .zip outside ./bin (../$artifact) and upload ./${{ steps.zip.outputs.artifact }} in .github/workflows/build-windows.yml.
  2. Add Excludes: "*.zip,*-setup.exe" to Source: "*" in Scripts/Windows/Libation.iss so local installer builds also never bundle .zip or -setup.exe artifacts.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant