The corpus counts AST nodes, not every dataclass - #76
Merged
Merged
Conversation
`node_kinds` counted any dataclass it walked into. `ChooseBranch` is a plain dataclass here — not an `ASTNode` subclass — and an interface with no `kind` field in TypeScript. So both implementations already agree it is a container rather than a node, and counting it was the one thing making them disagree: two corpus cases failed in the port for a representation difference neither side considers meaningful. Recursion is unchanged; only the counting is narrowed. Two results move, both `choose if ... includes ...`. Found on the first run of the node comparison against the port, which is the comparison doing its job — in the other direction, on itself. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01E6qcDj1e1dEYvc8jLnpGZy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
node_kindscounted any dataclass it walked into.ChooseBranchis a plain dataclass here — not anASTNodesubclass — and in TypeScript it is an interface with nokindfield. Both implementations already agree it is a container rather than a node. Counting it was the one thing making them disagree:Two corpus cases failed in the port for a representation difference neither side considers meaningful.
An
ASTNodesubclass is a node; another dataclass is a container. The walk still recurses through both — only the counting is narrowed. Two results move, bothchoose if ... includes ....Found on the first run of the node comparison against the port, which is the comparison doing its job in the other direction — on itself.
🤖 Generated with Claude Code
https://claude.ai/code/session_01E6qcDj1e1dEYvc8jLnpGZy