Handle out-of-range Unicode escapes as parse errors - #5710
Merged
rmosolgo merged 1 commit intoAug 27, 2026
Conversation
Owner
|
Cool, thanks 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An out-of-range Unicode escape currently causes
GraphQL::Language::Lexerto raise a rawRangeError:This happens when replace_escaped_characters_in_place passes the decoded codepoint to Array#pack("U"). Since the exception bypasses GraphQL's parse error handling, applications may return an HTTP 500 for an invalid query.
This PR catches that RangeError and reports it through the lexer's existing raise_parse_error path. The same query is now returned as a normal GraphQL parse error.
A regression test covers Unicode escapes above the valid codepoint range.