Support short braced Unicode escapes - #5712
Merged
rmosolgo merged 1 commit intoAug 27, 2026
Merged
Conversation
Owner
|
Thanks for this improvement! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GraphQL's braced Unicode escape syntax accepts one or more hexadecimal digits. However, both GraphQL-Ruby lexers currently require at least four digits, so valid escapes such as
\u{A}and\u{48}are rejected as malformed strings.This PR updates the Ruby and Ragel lexer patterns to accept one or more digits inside braced Unicode escapes, then regenerates the C lexer. The unbraced
\uXXXXform continues to require exactly four digits.Shared regression tests verify that
\u{A}and\u{48}are decoded correctly by both the Ruby and C lexers. Empty and non-hexadecimal escapes continue to be rejected.