Reject non-finite Float values - #5713
Merged
Merged
Conversation
Owner
|
Looks good to me. This might result in errors being raised where previously these values were being allowed through, but this is correct according to the spec:
https://spec.graphql.org/September2025/#sel-GAHXTFHCAACIBx4Q |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GraphQL Float values must be finite, but
GraphQL::Types::Floatcurrently accepts anyNumericvalue after callingto_f.This allows non-finite values through both input and result coercion:
Variables containing
Float::NANorinfinityare also accepted. For result values, the failure occurs later during HTTP response serialization instead of being reported by GraphQL-Ruby.This PR adds finite-value checks to
Floatcoercion, following the existing Int error-handling pattern. Invalid inputs are routed throughSchema#type_errorusingFloatDecodingError, while invalid result values raiseFloatEncodingErrorwith field and response-path context.Variable validation errors and serialized GraphQL values also represent non-finite floats as strings, keeping error responses JSON-safe.