Restore current multiplex after nested execution - #5714
Merged
rmosolgo merged 1 commit intoAug 27, 2026
Merged
Conversation
Owner
|
Thanks for this fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nested GraphQL execution currently clears the outer execution's fiber-local multiplex.
This can happen when a resolver executes another schema, for example while triggering subscriptions or composing an internal GraphQL API:
Both
GraphQL::Execution::InterpreterandGraphQL::Execution::RunnerreplaceFiber[:__graphql_current_multiplex]when execution starts, then unconditionally set it to nil in ensure. As a result, the outer multiplex is lost after the nested query finishes.Besides breaking
GraphQL::Current.operation_name, this can cause later dataloader runs to lose their current trace because they read it from the same fiber-local multiplex.This PR saves the previous multiplex before starting execution and restores it in ensure. Top-level execution continues to restore nil, while nested execution returns to the outer multiplex.