-
Notifications
You must be signed in to change notification settings - Fork 0
Schema generator PR doesn't stay up to date with master #32
Copy link
Copy link
Open
Labels
Module: SchemasIssues pertaining to the @mcsb/schemas package.Issues pertaining to the @mcsb/schemas package.Priority: LowIssues which aren't critical, security-related, or significantly beneficial to users.Issues which aren't critical, security-related, or significantly beneficial to users.Type: BugIssues that are about something which isn't working as expected.Issues that are about something which isn't working as expected.
Description
Activity
Metadata
Metadata
Assignees
Labels
Module: SchemasIssues pertaining to the @mcsb/schemas package.Issues pertaining to the @mcsb/schemas package.Priority: LowIssues which aren't critical, security-related, or significantly beneficial to users.Issues which aren't critical, security-related, or significantly beneficial to users.Type: BugIssues that are about something which isn't working as expected.Issues that are about something which isn't working as expected.
The schema generator's base branch does not automatically stay up to date with master. This is so we can stack multiple generator outputs into one PR (i.e. if the generator PR isn't merged for a week, if we want all of the generations to be included in the PR, we need to base each generation on the previous one). On the flip side, this means if master gets ahead, we need to somehow get our PR up to date.
I think if the action should check if we can gracefully rebase
schemas/patchontomaster, and do it if so. If not, resetschemas/patchback tomaster, thereby discarding changes, before running the generator again.For now, we can manually rebase the branch, or close the PR and delete the branch to discard changes.