Repository navigation
Support HIDENAMES and CLEARDATA as rumble settings - #9
Merged
Merged
Conversation
flemming-n-larsen
force-pushed
the
rumble-hidenames-cleardata
branch
from
November 1, 2026 14:34
ce32550 to
a77bcf3
Compare
flemming-n-larsen
force-pushed
the
accept-clients-1.11.2-1.12.0
branch
from
November 1, 2026 14:34
4bf63b5 to
7065eb3
Compare
This was referenced Nov 1, 2026
jkflying
force-pushed
the
rumble-hidenames-cleardata
branch
from
November 1, 2026 20:55
a77bcf3 to
1dfc17f
Compare
jkflying
approved these changes
Nov 1, 2026
jkflying
approved these changes
Nov 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Robocode 1.12.0 adds two client settings from Chase-san,
HIDENAMESandCLEARDATA(robo-code/robocode#117 and #118), both off by default. A client that turns them on sendshidenames=YESorcleardata=YES. Today LiteRumble ignores these, so those battles would be mixed into rumbles that were run without them.This makes them rumble settings like rounds, field, melee and teams. A new rumble takes them from its first upload, and later uploads have to match. Existing rumbles default to off, so they stay as they are and reject results with either setting on. Uploads without the settings work as before. The values are stripped because the client ends each upload with a line break, so the last field can arrive as
YES\n.This also adds 1.12.0 to
allowed_clients, so LiteRumble only accepts that version once it handles these settings. It builds on the client PR, so please merge that one first.Two things for you to decide: a rejected upload only shows in the server log, as it does for the other settings, and the rumble lists don't show these settings yet. New rumbles would also use your server resources, so tell me if you'd rather handle this differently.
There's no hurry on our side. We can release 1.12.0 without this, and rumble clients can stay on an accepted version until you've had time to look at it.